core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp - Issue 1294933008: Merge to XFA: Extern in .cpp file is a code smell, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

Issue 1294933008: Merge to XFA: Extern in .cpp file is a code smell, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: IWYU Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

diff --git a/core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp b/core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

index 50388332f80b11648f9525934b5b65b8e524866b..eff7b06e679a71709e921a9164a5cc3a6a1c8c86 100644

--- a/core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

+++ b/core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

@@ -9,7 +9,7 @@

#include "../../../include/fpdfapi/fpdf_pageobj.h"

#include "../fpdf_page/pageint.h"

#include "render_int.h"

-extern FX_BOOL IsAvailableMatrix(const CFX_AffineMatrix& matrix);

CPDF_Type3Cache::~CPDF_Type3Cache() {

for (const auto& pair : m_SizeMap) {

delete pair.second;