Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1293563003: Put clear and discard into GrBatch. (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
joshualitt
CC:
review_skia.org
Base URL:
https://skia.googlesource.com/skia.git@protectedprepare
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : working #

Patch Set 3 : update #

Patch Set 4 : more #

Patch Set 5 : tiny #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -161 lines) Patch
M gyp/gpu.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkStringUtils.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkStringUtils.cpp View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
M src/gpu/GrBufferedDrawTarget.h View 1 3 chunks +1 line, -6 lines 0 comments Download
M src/gpu/GrBufferedDrawTarget.cpp View 1 2 chunks +1 line, -13 lines 0 comments Download
M src/gpu/GrCommandBuilder.h View 1 3 chunks +1 line, -6 lines 0 comments Download
M src/gpu/GrCommandBuilder.cpp View 1 2 chunks +0 lines, -23 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 4 chunks +4 lines, -7 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 chunks +14 lines, -2 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.h View 1 2 chunks +1 line, -6 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.cpp View 1 3 chunks +1 line, -14 lines 0 comments Download
M src/gpu/GrInOrderCommandBuilder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderCommandBuilder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrReorderCommandBuilder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrReorderCommandBuilder.cpp View 1 2 3 5 chunks +6 lines, -33 lines 0 comments Download
M src/gpu/GrTargetCommands.h View 1 2 3 4 4 chunks +10 lines, -25 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 1 2 chunks +2 lines, -18 lines 0 comments Download
M src/gpu/batches/GrBatch.h View 1 3 chunks +19 lines, -0 lines 0 comments Download
A src/gpu/batches/GrClearBatch.h View 1 1 chunk +55 lines, -0 lines 0 comments Download
A src/gpu/batches/GrDiscardBatch.h View 1 1 chunk +48 lines, -0 lines 0 comments Download
M src/gpu/batches/GrDrawBatch.h View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M src/gpu/batches/GrVertexBatch.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrVertexBatch.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293563003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293563003/60001
5 years, 4 months ago (2015-08-18 15:23:58 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293563003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293563003/80001
5 years, 4 months ago (2015-08-18 15:35:54 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-18 15:42:07 UTC) #7
joshualitt
On 2015/08/18 15:42:07, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 4 months ago (2015-08-18 15:59:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293563003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293563003/80001
5 years, 4 months ago (2015-08-18 16:19:34 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 16:20:14 UTC) #11
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/5346983b2e0726b4009cc546b01c58a8919e6c36

Powered by Google App Engine
This is Rietveld 408576698