Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1893)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

Issue 1292923004: Refactor chrome's action mode logics and namings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make webview to compile Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
index a741439c35e8f5d4ce85b1d884fc7fb2213a8f3f..15c6b771e842c091b9d94259b12d73329b56873a 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
@@ -13,7 +13,7 @@ import android.view.View;
import android.view.View.MeasureSpec;
import org.chromium.base.Log;
-import org.chromium.content.browser.SelectActionModeCallback.ActionHandler;
+import org.chromium.content.browser.WebActionModeCallback.ActionHandler;
/**
* Main callback class used by ContentView.
@@ -93,13 +93,13 @@ public class ContentViewClient {
* feature is unsupported, the return value will be null.
* @return the SelectActionMode if creation is successful, otherwise null.
*/
- public SelectActionMode startActionMode(
+ public WebActionMode startActionMode(
View view, ActionHandler actionHandler, boolean floating) {
if (floating) return null;
ActionMode.Callback callback =
- new SelectActionModeCallback(view.getContext(), actionHandler);
+ new WebActionModeCallback(view.getContext(), actionHandler);
ActionMode actionMode = view.startActionMode(callback);
- return actionMode != null ? new SelectActionMode(actionMode) : null;
+ return actionMode != null ? new WebActionMode(actionMode) : null;
}
/**

Powered by Google App Engine
This is Rietveld 408576698