Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 1292923004: Refactor chrome's action mode logics and namings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make webview to compile Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 9e23233594275c70208d5129b9c028e5e4d4a468..16d909966ed0e34de471db803c164a685803e38f 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -521,11 +521,11 @@ public class ContentViewCore implements
private boolean mHasInsertion;
private String mLastSelectedText;
private boolean mFocusedNodeEditable;
- private SelectActionMode mActionMode;
+ private WebActionMode mActionMode;
private boolean mFloatingActionModeCreationFailed;
private boolean mUnselectAllOnActionModeDismiss;
private boolean mPreserveSelectionOnNextLossOfFocus;
- private SelectActionModeCallback.ActionHandler mActionHandler;
+ private WebActionModeCallback.ActionHandler mActionHandler;
private final Rect mSelectionRect = new Rect();
// Delegate that will handle GET downloads, and be notified of completion of POST downloads.
@@ -2012,7 +2012,7 @@ public class ContentViewCore implements
}
@VisibleForTesting
- public SelectActionModeCallback.ActionHandler getSelectActionHandler() {
+ public WebActionModeCallback.ActionHandler getSelectActionHandler() {
return mActionHandler;
}
@@ -2022,9 +2022,9 @@ public class ContentViewCore implements
return;
}
- // Start a new action mode with a SelectActionModeCallback.
+ // Start a new action mode with a WebActionModeCallback.
if (mActionHandler == null) {
- mActionHandler = new SelectActionModeCallback.ActionHandler() {
+ mActionHandler = new WebActionModeCallback.ActionHandler() {
@Override
public void selectAll() {
mWebContents.selectAll();

Powered by Google App Engine
This is Rietveld 408576698