Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Issue 12919016: Merge 142928 "Crash when selecting a HarfBuzz text run with SVG ..." (Closed)

Created:
7 years, 9 months ago by tony
Modified:
7 years, 9 months ago
Reviewers:
Stephen Chennney
CC:
chromium-reviews
Base URL:
https://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 142928 "Crash when selecting a HarfBuzz text run with SVG ..." > Crash when selecting a HarfBuzz text run with SVG fonts included > https://bugs.webkit.org/show_bug.cgi?id=109833 > > Reviewed by Tony Chang. > > Source/WebCore: > > There is an assert in SimpleFontData::applyTransforms that should not > be there, as the code is valid for SVG fonts. If we get past this, > then the HarfBuzz text run shaping code assumes that font data has a > SkTypeface member, and SVG fonts do not. So we crash there too. > > For now, we fix the crashes. This still leaves incorrect selection > rectangles in this situation, on all platforms, tracked in > https://bugs.webkit.org/show_bug.cgi?id=108133 > > Test: svg/css/font-face-crash.html > > * platform/graphics/SimpleFontData.h: > (WebCore::SimpleFontData::applyTransforms): Remove ASSERT_NOT_REACHED as the code can legally be reached for SVG fonts. > * platform/graphics/harfbuzz/HarfBuzzShaper.cpp: > (WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Check for SVG fonts in the text run, and abort if we find them. > > LayoutTests: > > Only known to crash on Chromium Linux (without the patch), but other platforms may be affected. > > * svg/css/font-face-crash-expected.txt: Added. > * svg/css/font-face-crash.html: Added. > TBR=schenney@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14225 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +0 lines, -14226 lines 0 comments Download
A + LayoutTests/svg/css/font-face-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/css/font-face-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/platform/graphics/SimpleFontData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
7 years, 9 months ago (2013-03-18 20:26:24 UTC) #1
tony
7 years, 9 months ago (2013-03-18 20:26:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r146113.

Powered by Google App Engine
This is Rietveld 408576698