Source/WebCore/platform/graphics/SimpleFontData.h - Issue 12919016: Merge 142928 "Crash when selecting a HarfBuzz text run with SVG ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/platform/graphics/SimpleFontData.h

Issue 12919016: Merge 142928 "Crash when selecting a HarfBuzz text run with SVG ..." (Closed) Base URL: https://svn.webkit.org/repository/webkit/branches/chromium/1410/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/css/font-face-crash-expected.txt ('k') | Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/platform/graphics/SimpleFontData.h

===================================================================

--- Source/WebCore/platform/graphics/SimpleFontData.h (revision 146110)

+++ Source/WebCore/platform/graphics/SimpleFontData.h (working copy)

@@ -206,7 +206,6 @@

UNUSED_PARAM(advances);

UNUSED_PARAM(glyphCount);

UNUSED_PARAM(typesettingFeatures);

- ASSERT_NOT_REACHED();

return false;

#else

wkCTFontTransformOptions options = (typesettingFeatures & Kerning ? wkCTFontTransformApplyPositioning : 0) | (typesettingFeatures & Ligatures ? wkCTFontTransformApplyShaping : 0);

« no previous file with comments | « LayoutTests/svg/css/font-face-crash-expected.txt ('k') | Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp » ('j') | no next file with comments »