Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp - Issue 12919016: Merge 142928 "Crash when selecting a HarfBuzz text run with SVG ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp

Issue 12919016: Merge 142928 "Crash when selecting a HarfBuzz text run with SVG ..." (Closed) Base URL: https://svn.webkit.org/repository/webkit/branches/chromium/1410/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp

===================================================================

--- Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp (revision 146110)

+++ Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp (working copy)

@@ -323,6 +323,8 @@

unsigned runIndex = m_run.rtl() ? m_harfBuzzRuns.size() - i - 1 : i;

HarfBuzzRun* currentRun = m_harfBuzzRuns[runIndex].get();

const SimpleFontData* currentFontData = currentRun->fontData();

+ if (currentFontData->isSVGFont())

+ return false;

hb_buffer_set_script(harfBuzzBuffer.get(), currentRun->script());

if (shouldSetDirection)

« no previous file with comments | « Source/WebCore/platform/graphics/SimpleFontData.h ('k') | no next file » | no next file with comments »