DescriptionMerge 142928 "Crash when selecting a HarfBuzz text run with SVG ..."
> Crash when selecting a HarfBuzz text run with SVG fonts included
> https://bugs.webkit.org/show_bug.cgi?id=109833
>
> Reviewed by Tony Chang.
>
> Source/WebCore:
>
> There is an assert in SimpleFontData::applyTransforms that should not
> be there, as the code is valid for SVG fonts. If we get past this,
> then the HarfBuzz text run shaping code assumes that font data has a
> SkTypeface member, and SVG fonts do not. So we crash there too.
>
> For now, we fix the crashes. This still leaves incorrect selection
> rectangles in this situation, on all platforms, tracked in
> https://bugs.webkit.org/show_bug.cgi?id=108133
>
> Test: svg/css/font-face-crash.html
>
> * platform/graphics/SimpleFontData.h:
> (WebCore::SimpleFontData::applyTransforms): Remove ASSERT_NOT_REACHED as the code can legally be reached for SVG fonts.
> * platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
> (WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Check for SVG fonts in the text run, and abort if we find them.
>
> LayoutTests:
>
> Only known to crash on Chromium Linux (without the patch), but other platforms may be affected.
>
> * svg/css/font-face-crash-expected.txt: Added.
> * svg/css/font-face-crash.html: Added.
>
TBR=schenney@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146113
Patch Set 1 #
Created: 7 years, 9 months ago
(Patch set is too large to download)
Messages
Total messages: 2 (0 generated)
|