DevTools: make V8DebuggerAgent call Client instead of overriden methods

DevTools: make V8DebuggerAgent call Client instead of overriden methods

V8DebuggerAgent is going to be aggregated by InspectorDebuggerAgent. This CL cmakes
one step towards it by turning InspectorDebgugerAgent into V8DebuggerAgent::Client.

V8DebuggerAgent::Listener was moved into InspectorDebuggerAgent.

BUG=439376
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200372

[yurys, 2015-08-12 00:16:25]

yurys@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org, sergeyv@chromium.org

[yurys, 2015-08-12 00:16:30]

The CQ bit was checked by yurys@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-12 00:17:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1291613002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1291613002/1

[sergeyv, 2015-08-12 00:26:54]

lgtm

https://codereview.chromium.org/1291613002/diff/1/Source/core/inspector/V8Deb...
File Source/core/inspector/V8DebuggerAgent.h (right):

https://codereview.chromium.org/1291613002/diff/1/Source/core/inspector/V8Deb...
Source/core/inspector/V8DebuggerAgent.h:64: virtual InjectedScript
injectedScriptForEval(ErrorString*, const int* executionContextId) = 0;
you should be more creative

[yurys, 2015-08-12 00:42:34]

https://codereview.chromium.org/1291613002/diff/1/Source/core/inspector/V8Deb...
File Source/core/inspector/V8DebuggerAgent.h (right):

https://codereview.chromium.org/1291613002/diff/1/Source/core/inspector/V8Deb...
Source/core/inspector/V8DebuggerAgent.h:64: virtual InjectedScript
injectedScriptForEval(ErrorString*, const int* executionContextId) = 0;
On 2015/08/12 00:26:54, sergeyv wrote:
> you should be more creative

Done.

[yurys, 2015-08-12 00:42:37]

The CQ bit was checked by yurys@chromium.org

[yurys, 2015-08-12 00:42:38]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyv@chromium.org
Link to the patchset: https://codereview.chromium.org/1291613002/#ps20001
(title: "Changed Client to only return defaultInjectedScript")

[commit-bot: I haz the power, 2015-08-12 00:42:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1291613002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1291613002/20001

[dgozman, 2015-08-12 02:00:05]

https://codereview.chromium.org/1291613002/diff/20001/Source/core/inspector/I...
File Source/core/inspector/InspectorDebuggerAgent.h (right):

https://codereview.chromium.org/1291613002/diff/20001/Source/core/inspector/I...
Source/core/inspector/InspectorDebuggerAgent.h:60: virtual bool
canPauseOnPromiseEvent() = 0;
canPauseXXX is a strange method for the Listener.

https://codereview.chromium.org/1291613002/diff/20001/Source/core/inspector/V...
File Source/core/inspector/V8DebuggerAgent.cpp (right):

https://codereview.chromium.org/1291613002/diff/20001/Source/core/inspector/V...
Source/core/inspector/V8DebuggerAgent.cpp:181:
m_client->startListeningV8Debugger();
Having this to go through client is awkward.

[commit-bot: I haz the power, 2015-08-12 02:24:33]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200372