Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: Source/core/inspector/InspectorDebuggerAgent.cpp

Issue 1291613002: DevTools: make V8DebuggerAgent call Client instead of overriden methods (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Changed Client to only return defaultInjectedScript Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorDebuggerAgent.cpp
diff --git a/Source/core/inspector/InspectorDebuggerAgent.cpp b/Source/core/inspector/InspectorDebuggerAgent.cpp
index 13cc126397207ca1eac2edc6960f11830cd6bf1d..a29c1f3bf69847fd8f7b9492d7c7c8ee82bc350d 100644
--- a/Source/core/inspector/InspectorDebuggerAgent.cpp
+++ b/Source/core/inspector/InspectorDebuggerAgent.cpp
@@ -33,7 +33,8 @@
namespace blink {
InspectorDebuggerAgent::InspectorDebuggerAgent(InjectedScriptManager* injectedScriptManager, V8Debugger* debugger)
- : V8DebuggerAgent(injectedScriptManager, debugger)
+ : V8DebuggerAgent(injectedScriptManager, debugger, this)
+ , m_listener(nullptr)
{
}
@@ -44,21 +45,54 @@ InspectorDebuggerAgent::~InspectorDebuggerAgent()
#endif
}
+DEFINE_TRACE(InspectorDebuggerAgent)
+{
+#if ENABLE(OILPAN)
+ visitor->trace(m_listener);
+#endif
+ V8DebuggerAgent::trace(visitor);
+}
+
void InspectorDebuggerAgent::enable(ErrorString* errorString)
{
V8DebuggerAgent::enable(errorString);
}
-void InspectorDebuggerAgent::enable()
+void InspectorDebuggerAgent::startListeningV8Debugger()
{
m_instrumentingAgents->setInspectorDebuggerAgent(this);
- V8DebuggerAgent::enable();
+ if (m_listener)
+ m_listener->debuggerWasEnabled();
}
-void InspectorDebuggerAgent::disable()
+void InspectorDebuggerAgent::stopListeningV8Debugger()
{
m_instrumentingAgents->setInspectorDebuggerAgent(nullptr);
- V8DebuggerAgent::disable();
+ if (m_listener)
+ m_listener->debuggerWasDisabled();
+}
+
+bool InspectorDebuggerAgent::canPauseOnPromiseEvent()
+{
+ return m_listener && m_listener->canPauseOnPromiseEvent();
+}
+
+void InspectorDebuggerAgent::didCreatePromise()
+{
+ if (m_listener)
+ m_listener->didCreatePromise();
+}
+
+void InspectorDebuggerAgent::didResolvePromise()
+{
+ if (m_listener)
+ m_listener->didResolvePromise();
+}
+
+void InspectorDebuggerAgent::didRejectPromise()
+{
+ if (m_listener)
+ m_listener->didRejectPromise();
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698