Source/core/inspector/PageDebuggerAgent.h - Issue 1291613002: DevTools: make V8DebuggerAgent call Client instead of overriden methods

Side by Side Diff: Source/core/inspector/PageDebuggerAgent.h

Issue 1291613002: DevTools: make V8DebuggerAgent call Client instead of overriden methods (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changed Client to only return defaultInjectedScript Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/inspector/InspectorDebuggerAgent.h ('K') | « Source/core/inspector/InspectorDebuggerAgent.cpp ('k') | Source/core/inspector/PageDebuggerAgent.cpp » ('j') | Source/core/inspector/V8DebuggerAgent.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
58	58

59 void enable(ErrorString*) final;	59 void enable(ErrorString*) final;

60 void restore() final;	60 void restore() final;

61 void compileScript(ErrorString, const String& expression, const String& sou rceURL, bool persistScript, const int executionContextId, TypeBuilder::OptOutpu t<TypeBuilder::Debugger::ScriptId>*, RefPtr<TypeBuilder::Debugger::ExceptionDeta ils>&) override;	61 void compileScript(ErrorString, const String& expression, const String& sou rceURL, bool persistScript, const int executionContextId, TypeBuilder::OptOutpu t<TypeBuilder::Debugger::ScriptId>*, RefPtr<TypeBuilder::Debugger::ExceptionDeta ils>&) override;

62 void runScript(ErrorString, const TypeBuilder::Debugger::ScriptId&, const i nt executionContextId, const String* objectGroup, const bool* doNotPauseOnExcep tionsAndMuteConsole, RefPtr<TypeBuilder::Runtime::RemoteObject>& result, RefPtr< TypeBuilder::Debugger::ExceptionDetails>&) override;	62 void runScript(ErrorString, const TypeBuilder::Debugger::ScriptId&, const i nt executionContextId, const String* objectGroup, const bool* doNotPauseOnExcep tionsAndMuteConsole, RefPtr<TypeBuilder::Runtime::RemoteObject>& result, RefPtr< TypeBuilder::Debugger::ExceptionDetails>&) override;

63	63

64 void didStartProvisionalLoad(LocalFrame*);	64 void didStartProvisionalLoad(LocalFrame*);

65 void didClearDocumentOfWindowObject(LocalFrame*);	65 void didClearDocumentOfWindowObject(LocalFrame*);

66 void didCommitLoadForLocalFrame(LocalFrame*) override;	66 void didCommitLoadForLocalFrame(LocalFrame*) override;

67	67

68 protected:

69 void enable() override;

70 void disable() override;

71

72 private:	68 private:

	69 // V8DebuggerAgent::Client implemntation.

73 void startListeningV8Debugger() override;	70 void startListeningV8Debugger() override;

74 void stopListeningV8Debugger() override;	71 void stopListeningV8Debugger() override;

75 void muteConsole() override;	72 void muteConsole() override;

76 void unmuteConsole() override;	73 void unmuteConsole() override;

77	74

78 // InspectorOverlay::Listener implementation.	75 // InspectorOverlay::Listener implementation.

79 void overlayResumed() override;	76 void overlayResumed() override;

80 void overlaySteppedOver() override;	77 void overlaySteppedOver() override;

81	78

82 InjectedScript injectedScriptForEval(ErrorString, const int executionConte xtId) override;	79 InjectedScript defaultInjectedScript() override;

83 bool canExecuteScripts() const;	80 bool canExecuteScripts() const;

84	81

85 PageDebuggerAgent(MainThreadDebugger, InspectorPageAgent, InjectedScriptMa nager, InspectorOverlay);	82 PageDebuggerAgent(MainThreadDebugger, InspectorPageAgent, InjectedScriptMa nager, InspectorOverlay);

86 MainThreadDebugger* m_mainThreadDebugger;	83 MainThreadDebugger* m_mainThreadDebugger;

87 RawPtrWillBeMember<InspectorPageAgent> m_pageAgent;	84 RawPtrWillBeMember<InspectorPageAgent> m_pageAgent;

88 RawPtrWillBeMember<InspectorOverlay> m_overlay;	85 RawPtrWillBeMember<InspectorOverlay> m_overlay;

89 HashMap<String, String> m_compiledScriptURLs;	86 HashMap<String, String> m_compiledScriptURLs;

90 };	87 };

91	88

92 } // namespace blink	89 } // namespace blink

93	90

94	91

95 #endif // !defined(PageDebuggerAgent_h)	92 #endif // !defined(PageDebuggerAgent_h)

OLD	NEW