Source/core/inspector/PageDebuggerAgent.h - Issue 1291613002: DevTools: make V8DebuggerAgent call Client instead of overriden methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/PageDebuggerAgent.h

Issue 1291613002: DevTools: make V8DebuggerAgent call Client instead of overriden methods (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changed Client to only return defaultInjectedScript Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/inspector/InspectorDebuggerAgent.h ('K') | « Source/core/inspector/InspectorDebuggerAgent.cpp ('k') | Source/core/inspector/PageDebuggerAgent.cpp » ('j') | Source/core/inspector/V8DebuggerAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/PageDebuggerAgent.h

diff --git a/Source/core/inspector/PageDebuggerAgent.h b/Source/core/inspector/PageDebuggerAgent.h

index 61a68c7c32ff0c8c8eff31d471a72ea4ddc293eb..8e93c6c1f318df069d31fb015e61435e7c5a4643 100644

--- a/Source/core/inspector/PageDebuggerAgent.h

+++ b/Source/core/inspector/PageDebuggerAgent.h

@@ -65,11 +65,8 @@ public:

void didClearDocumentOfWindowObject(LocalFrame*);

void didCommitLoadForLocalFrame(LocalFrame*) override;

-protected:

- void enable() override;

- void disable() override;

private:

+ // V8DebuggerAgent::Client implemntation.

void startListeningV8Debugger() override;

void stopListeningV8Debugger() override;

void muteConsole() override;

@@ -79,7 +76,7 @@ private:

void overlayResumed() override;

void overlaySteppedOver() override;

- InjectedScript injectedScriptForEval(ErrorString*, const int* executionContextId) override;

+ InjectedScript defaultInjectedScript() override;

bool canExecuteScripts() const;

PageDebuggerAgent(MainThreadDebugger*, InspectorPageAgent*, InjectedScriptManager*, InspectorOverlay*);