Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1337)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290683003: Remove WeakPtrs from DocumentTiming/DocumentLoadTiming (Closed)

Created:
5 years, 4 months ago by Charlie Harrison
Modified:
5 years, 4 months ago
Reviewers:
sof, dcheng
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, oilpan-reviews, rwlbuis, sof, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

got rid of weak_ptr from DocumentTiming and DocumentLoadTiming used a RawPtrWillBeMember instead because Oilpan can deal with these ownership cycles BUG=382542 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200759

Patch Set 1 #

Total comments: 3

Patch Set 2 : Constructor edits #

Patch Set 3 : WeakPtrWillBeRawPtr<Document>(nullptr) => nullptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -36 lines) Patch
M Source/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 2 2 chunks +5 lines, -10 lines 0 comments Download
M Source/core/dom/DocumentTiming.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentTiming.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/loader/DocumentLoadTiming.h View 1 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/loader/DocumentLoadTiming.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Charlie Harrison
Got rid of the WeakPtrs for RawPtrWillBeMember in DocumentTiming/DocumentLoadTiming
5 years, 4 months ago (2015-08-18 18:50:32 UTC) #2
sof
https://codereview.chromium.org/1290683003/diff/1/Source/core/dom/DocumentTiming.h File Source/core/dom/DocumentTiming.h (right): https://codereview.chromium.org/1290683003/diff/1/Source/core/dom/DocumentTiming.h#newcode38 Source/core/dom/DocumentTiming.h:38: DocumentTiming(RawPtrWillBeMember<Document>); Make this explicit DocumentTiming(Document&); https://codereview.chromium.org/1290683003/diff/1/Source/core/loader/DocumentLoadTiming.h File Source/core/loader/DocumentLoadTiming.h (right): ...
5 years, 4 months ago (2015-08-18 19:13:48 UTC) #4
dcheng
https://codereview.chromium.org/1290683003/diff/1/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/1290683003/diff/1/Source/core/dom/Document.cpp#newcode4403 Source/core/dom/Document.cpp:4403: return WeakPtrWillBeRawPtr<Document>(nullptr); I think nullptr by itself should work ...
5 years, 4 months ago (2015-08-18 19:25:32 UTC) #5
Charlie Harrison
Made review edits to simplify interface.
5 years, 4 months ago (2015-08-18 19:37:21 UTC) #6
sof
lgtm, thanks for the quick followup.
5 years, 4 months ago (2015-08-18 20:11:44 UTC) #7
Charlie Harrison
On 2015/08/18 20:11:44, sof wrote: > lgtm, thanks for the quick followup. No problem, thanks ...
5 years, 4 months ago (2015-08-18 20:16:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290683003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290683003/40001
5 years, 4 months ago (2015-08-18 20:16:53 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 22:10:36 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200759

Powered by Google App Engine
This is Rietveld 408576698