Chromium Code Reviews Chromium Code Reviews
Issue 1290683003:
Remove WeakPtrs from DocumentTiming/DocumentLoadTiming (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2010 Google, Inc. All Rights Reserved. | 2 * Copyright (C) 2010 Google, Inc. All Rights Reserved. |
| 3 * | 3 * |
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
| 5 * modification, are permitted provided that the following conditions | 5 * modification, are permitted provided that the following conditions |
| 6 * are met: | 6 * are met: |
| 7 * 1. Redistributions of source code must retain the above copyright | 7 * 1. Redistributions of source code must retain the above copyright |
| 8 * notice, this list of conditions and the following disclaimer. | 8 * notice, this list of conditions and the following disclaimer. |
| 9 * 2. Redistributions in binary form must reproduce the above copyright | 9 * 2. Redistributions in binary form must reproduce the above copyright |
| 10 * notice, this list of conditions and the following disclaimer in the | 10 * notice, this list of conditions and the following disclaimer in the |
| (...skipping 17 matching lines...) Expand all Loading... | |
| 28 | 28 |
| 29 #include "platform/heap/Handle.h" | 29 #include "platform/heap/Handle.h" |
| 30 | 30 |
| 31 namespace blink { | 31 namespace blink { |
| 32 | 32 |
| 33 class Document; | 33 class Document; |
| 34 | 34 |
| 35 class DocumentTiming final { | 35 class DocumentTiming final { |
| 36 DISALLOW_ALLOCATION(); | 36 DISALLOW_ALLOCATION(); |
| 37 public: | 37 public: |
| 38 DocumentTiming(WeakPtrWillBeRawPtr<Document>); | 38 DocumentTiming(RawPtrWillBeMember<Document>); |
|
sof
2015/08/18 19:13:48
Make this
explicit DocumentTiming(Document&);
| |
| 39 | 39 |
| 40 void markDomLoading(); | 40 void markDomLoading(); |
| 41 void markDomInteractive(); | 41 void markDomInteractive(); |
| 42 void markDomContentLoadedEventStart(); | 42 void markDomContentLoadedEventStart(); |
| 43 void markDomContentLoadedEventEnd(); | 43 void markDomContentLoadedEventEnd(); |
| 44 void markDomComplete(); | 44 void markDomComplete(); |
| 45 void markFirstLayout(); | 45 void markFirstLayout(); |
| 46 | 46 |
| 47 double domLoading() const { return m_domLoading; } | 47 double domLoading() const { return m_domLoading; } |
| 48 double domInteractive() const { return m_domInteractive; } | 48 double domInteractive() const { return m_domInteractive; } |
| 49 double domContentLoadedEventStart() const { return m_domContentLoadedEventSt art; } | 49 double domContentLoadedEventStart() const { return m_domContentLoadedEventSt art; } |
| 50 double domContentLoadedEventEnd() const { return m_domContentLoadedEventEnd; } | 50 double domContentLoadedEventEnd() const { return m_domContentLoadedEventEnd; } |
| 51 double domComplete() const { return m_domComplete; } | 51 double domComplete() const { return m_domComplete; } |
| 52 double firstLayout() const { return m_firstLayout; } | 52 double firstLayout() const { return m_firstLayout; } |
| 53 | 53 |
| 54 DECLARE_TRACE(); | 54 DECLARE_TRACE(); |
| 55 | 55 |
| 56 private: | 56 private: |
| 57 void notifyDocumentTimingChanged(); | 57 void notifyDocumentTimingChanged(); |
| 58 | 58 |
| 59 double m_domLoading; | 59 double m_domLoading; |
| 60 double m_domInteractive; | 60 double m_domInteractive; |
| 61 double m_domContentLoadedEventStart; | 61 double m_domContentLoadedEventStart; |
| 62 double m_domContentLoadedEventEnd; | 62 double m_domContentLoadedEventEnd; |
| 63 double m_domComplete; | 63 double m_domComplete; |
| 64 double m_firstLayout; | 64 double m_firstLayout; |
| 65 | 65 |
| 66 WeakPtrWillBeMember<Document> m_document; | 66 RawPtrWillBeMember<Document> m_document; |
| 67 }; | 67 }; |
| 68 | 68 |
| 69 } | 69 } |
| 70 | 70 |
| 71 #endif | 71 #endif |
| OLD | NEW |
