Source/core/loader/DocumentLoadTiming.h - Issue 1290683003: Remove WeakPtrs from DocumentTiming/DocumentLoadTiming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/DocumentLoadTiming.h

Issue 1290683003: Remove WeakPtrs from DocumentTiming/DocumentLoadTiming (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WeakPtrWillBeRawPtr<Document>(nullptr) => nullptr Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/DocumentLoadTiming.h

diff --git a/Source/core/loader/DocumentLoadTiming.h b/Source/core/loader/DocumentLoadTiming.h

index f5d461b4ef33e2298ab9a0300aa97108430ebb5c..6bd081ef2b1ec2feb63643fe41983047bd65e8d8 100644

--- a/Source/core/loader/DocumentLoadTiming.h

+++ b/Source/core/loader/DocumentLoadTiming.h

@@ -29,7 +29,6 @@

#include "core/CoreExport.h"

#include "platform/heap/Handle.h"

#include "wtf/CurrentTime.h"

-#include "wtf/WeakPtr.h"

namespace blink {

@@ -39,7 +38,7 @@ class KURL;

class CORE_EXPORT DocumentLoadTiming final {

DISALLOW_ALLOCATION();

public:

- DocumentLoadTiming(WeakPtrWillBeRawPtr<DocumentLoader>);

+ explicit DocumentLoadTiming(DocumentLoader&);

double monotonicTimeToZeroBasedDocumentTime(double) const;

double monotonicTimeToPseudoWallTime(double) const;

@@ -95,7 +94,7 @@ private:

bool m_hasCrossOriginRedirect;

bool m_hasSameOriginAsPreviousDocument;

- WeakPtrWillBeMember<DocumentLoader> m_documentLoader;

+ RawPtrWillBeMember<DocumentLoader> m_documentLoader;

};

} // namespace blink

« no previous file with comments | « Source/core/dom/DocumentTiming.cpp ('k') | Source/core/loader/DocumentLoadTiming.cpp » ('j') | no next file with comments »