Shift URLRequestContextStorage over to taking scoped_ptrs.

Shift URLRequestContextStorage over to taking scoped_ptrs.

Also includes converting several sources of scoped_ptrs for URLRequestContextStorage, including the ProxyService static generators and the ShellURLRequestContextGetter protected methods to be used by subclasses.

BUG=521705
Committed: https://crrev.com/82957ade8b7a9686c50688ab8caab3a19dcd80b1
Cr-Commit-Position: refs/heads/master@{#349194}

[Randy Smith (Not in Mondays), 2015-08-23 22:23:07]

rdsmith@chromium.org changed reviewers:
+ pauljensen@chromium.org

[Randy Smith (Not in Mondays), 2015-08-23 22:23:08]

Paul, PTAL?  I figured that since you had done this for URLRequestContextBuilder
you were a good person to review doing the same thing for
URLRequestContextStorage.  A couple of notes:
* There's a bit of mission creep here; in addition to making the various setters
for URLRCS take a scoped_ptr, I also made most of the functions that create
pointers for URLRCS produce/return scoped_ptrs.  This created the most churn in
the set of ProxyService statics used for creating a variety of ProxyServices.
* I also change the signature for three ShellURLRequestContextGetter methods
(CreateNetworkDelegate(), GetPRoxyConfigService(), and GetProxyService) to
return scoped_ptrs, which required altering subclasses as well.
* I did *not* change ProxyService::CreateSsytemProxyConfigService to return a
scoped_ptr<>, as that would have involved extensive changes to ProxyService and
I had run out of yak razors.  Charles (cc'd) was kind enough to take it on,
though, and will be reviewing his CL after mine lands (or gets well into the
landing process).

Let me know what you think ...

[pauljensen, 2015-08-24 00:17:07]

On 2015/08/23 22:23:08, rdsmith wrote:
> Paul, PTAL?  I figured that since you had done this for
URLRequestContextBuilder
> you were a good person to review doing the same thing for
> URLRequestContextStorage.  A couple of notes:
> * There's a bit of mission creep here; in addition to making the various
setters
> for URLRCS take a scoped_ptr, I also made most of the functions that create
> pointers for URLRCS produce/return scoped_ptrs.  This created the most churn
in
> the set of ProxyService statics used for creating a variety of ProxyServices.
> * I also change the signature for three ShellURLRequestContextGetter methods
> (CreateNetworkDelegate(), GetPRoxyConfigService(), and GetProxyService) to
> return scoped_ptrs, which required altering subclasses as well.
> * I did *not* change ProxyService::CreateSsytemProxyConfigService to return a
> scoped_ptr<>, as that would have involved extensive changes to ProxyService
and
> I had run out of yak razors.  Charles (cc'd) was kind enough to take it on,
> though, and will be reviewing his CL after mine lands (or gets well into the
> landing process).
> 
> Let me know what you think ...

I'm on vacation Mon-Wed.  I started writing this same CL last week, but I'm
totally fine with you finishing it :)

[pauljensen, 2015-08-28 13:38:03]

https://codereview.chromium.org/1290243007/diff/140001/chrome/browser/net/pro...
File chrome/browser/net/proxy_service_factory.h (right):

https://codereview.chromium.org/1290243007/diff/140001/chrome/browser/net/pro...
chrome/browser/net/proxy_service_factory.h:52: net::ProxyConfigService*
proxy_config_service,
This should be a scoped_ptr...dunno if you want to do it in this CL while you're
making a change here.

https://codereview.chromium.org/1290243007/diff/140001/components/data_reduct...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
(right):

https://codereview.chromium.org/1290243007/diff/140001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc:532:
scoped_ptr<net::NetworkDelegate>(new net::TestNetworkDelegate()),
I see lots of places in this CL where you've added scoped_ptr<>() instead of
make_scoped_ptr(), I assume because an implicit upcast is needed.
I wonder if this could be changed to make_scoped_ptr(...).Pass()?
We used to use .PassAs<>() but that was eliminated; now just Pass() is required.
This would make things more consistent (i.e. using make_scoped_ptr in all
places).
Some directories forbid scoped_ptr<>():
https://code.google.com/p/chromium/codesearch#chromium/src/ui/PRESUBMIT.py&l=34

https://codereview.chromium.org/1290243007/diff/140001/net/http/http_stream_f...
File net/http/http_stream_factory_impl_unittest.cc (right):

https://codereview.chromium.org/1290243007/diff/140001/net/http/http_stream_f...
net/http/http_stream_factory_impl_unittest.cc:519: 
unnecessary whitespace change?

https://codereview.chromium.org/1290243007/diff/140001/net/proxy/proxy_service.h
File net/proxy/proxy_service.h (right):

https://codereview.chromium.org/1290243007/diff/140001/net/proxy/proxy_servic...
net/proxy/proxy_service.h:97: ProxyService(ProxyConfigService* config_service,
Would really be nice to make this a scoped_ptr while making changes here.

https://codereview.chromium.org/1290243007/diff/140001/net/proxy/proxy_servic...
File net/proxy/proxy_service_v8.h (right):

https://codereview.chromium.org/1290243007/diff/140001/net/proxy/proxy_servic...
net/proxy/proxy_service_v8.h:42: ProxyConfigService* proxy_config_service,
would be nice to make this a scoped_ptr

https://codereview.chromium.org/1290243007/diff/140001/net/quic/test_tools/cr...
File net/quic/test_tools/crypto_test_utils_chromium.cc (right):

https://codereview.chromium.org/1290243007/diff/140001/net/quic/test_tools/cr...
net/quic/test_tools/crypto_test_utils_chromium.cc:27: TransportSecurityState*
transport_security_state,
would be nice to make this a scoped_ptr

https://codereview.chromium.org/1290243007/diff/140001/net/spdy/spdy_network_...
File net/spdy/spdy_network_transaction_unittest.cc (right):

https://codereview.chromium.org/1290243007/diff/140001/net/spdy/spdy_network_...
net/spdy/spdy_network_transaction_unittest.cc:116: SpdySessionDependencies*
CreateSpdySessionDependencies(
would be nice to make this a scoped_ptr too

https://codereview.chromium.org/1290243007/diff/140001/net/spdy/spdy_network_...
net/spdy/spdy_network_transaction_unittest.cc:4491: 
unnecessary whitespace change?

https://codereview.chromium.org/1290243007/diff/140001/net/spdy/spdy_network_...
net/spdy/spdy_network_transaction_unittest.cc:4588: 
ditto

https://codereview.chromium.org/1290243007/diff/140001/net/spdy/spdy_network_...
net/spdy/spdy_network_transaction_unittest.cc:4590: GetParam(),
ProxyService::CreateFixedFromPacResult("PROXY myproxy:70")));
a formatting change...to an unrelated line...perhaps precipitated by the change
on line 4588

https://codereview.chromium.org/1290243007/diff/140001/net/url_request/url_re...
File net/url_request/url_request_test_util.cc (right):

https://codereview.chromium.org/1290243007/diff/140001/net/url_request/url_re...
net/url_request/url_request_test_util.cc:83: make_scoped_ptr(new
TransportSecurityState));
some of these lines have "()" after constructor calls (e.g. line 76, 92) while
others do not (e.g. lines 83, 85).  perhaps we should make the style consistent.

[mmenke, 2015-08-28 19:36:46]

Just a heads up that I'm removing reference counting from HttpNetworkSession. 
This CL will probably land before min does, but just in case it doesn't, we'll
be stepping on each other's toes wherever an HttpCache object is saved in a
URLRequestContextStorage (I'm having the storage own the HttpNetworkSession -
since caches can share sessions, can't just have the HttpCache own it).

[Randy Smith (Not in Mondays), 2015-09-02 23:42:20]

Paul, comments incorporated; PTAL?

https://codereview.chromium.org/1290243007/diff/140001/chrome/browser/net/pro...
File chrome/browser/net/proxy_service_factory.h (right):

https://codereview.chromium.org/1290243007/diff/140001/chrome/browser/net/pro...
chrome/browser/net/proxy_service_factory.h:52: net::ProxyConfigService*
proxy_config_service,
On 2015/08/28 13:38:02, pauljensen wrote:
> This should be a scoped_ptr...dunno if you want to do it in this CL while
you're
> making a change here.

So the conversion of ProxyConfigService over to scoped_ptr<> is where I ran out
of yak razors; Charles is taking care of it in
https://codereview.chromium.org/1301333002.  If you think this CL is internally
inconsistent, I want to fix that.  But if the concern is just that this is a
conversion to scoped_ptr<> that would be worth doing, I'd rather leave that to
Charles' CL.

https://codereview.chromium.org/1290243007/diff/140001/components/data_reduct...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
(right):

https://codereview.chromium.org/1290243007/diff/140001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc:532:
scoped_ptr<net::NetworkDelegate>(new net::TestNetworkDelegate()),
On 2015/08/28 13:38:02, pauljensen wrote:
> I see lots of places in this CL where you've added scoped_ptr<>() instead of
> make_scoped_ptr(), I assume because an implicit upcast is needed.
> I wonder if this could be changed to make_scoped_ptr(...).Pass()?
> We used to use .PassAs<>() but that was eliminated; now just Pass() is
required.
> This would make things more consistent (i.e. using make_scoped_ptr in all
> places).
> Some directories forbid scoped_ptr<>():
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/PRESUBMIT.py&l=34

So "Done", with the exception of places where I'm returning a null scoped_ptr of
a particular type; I'm not sure how to do that with make_scoped_ptr.  An example
is LayoutTestURLRequestContextGetter::GetProxyConfigService().  Any ideas of
what the right idiom is in that case?

https://codereview.chromium.org/1290243007/diff/140001/net/http/http_stream_f...
File net/http/http_stream_factory_impl_unittest.cc (right):

https://codereview.chromium.org/1290243007/diff/140001/net/http/http_stream_f...
net/http/http_stream_factory_impl_unittest.cc:519: 
On 2015/08/28 13:38:02, pauljensen wrote:
> unnecessary whitespace change?

Done.

https://codereview.chromium.org/1290243007/diff/140001/net/proxy/proxy_service.h
File net/proxy/proxy_service.h (right):

https://codereview.chromium.org/1290243007/diff/140001/net/proxy/proxy_servic...
net/proxy/proxy_service.h:97: ProxyService(ProxyConfigService* config_service,
On 2015/08/28 13:38:02, pauljensen wrote:
> Would really be nice to make this a scoped_ptr while making changes here.

See other comment; being done in separate CL.

https://codereview.chromium.org/1290243007/diff/140001/net/proxy/proxy_servic...
File net/proxy/proxy_service_v8.h (right):

https://codereview.chromium.org/1290243007/diff/140001/net/proxy/proxy_servic...
net/proxy/proxy_service_v8.h:42: ProxyConfigService* proxy_config_service,
On 2015/08/28 13:38:02, pauljensen wrote:
> would be nice to make this a scoped_ptr

See other comment.

https://codereview.chromium.org/1290243007/diff/140001/net/quic/test_tools/cr...
File net/quic/test_tools/crypto_test_utils_chromium.cc (right):

https://codereview.chromium.org/1290243007/diff/140001/net/quic/test_tools/cr...
net/quic/test_tools/crypto_test_utils_chromium.cc:27: TransportSecurityState*
transport_security_state,
On 2015/08/28 13:38:02, pauljensen wrote:
> would be nice to make this a scoped_ptr

Done.

https://codereview.chromium.org/1290243007/diff/140001/net/spdy/spdy_network_...
File net/spdy/spdy_network_transaction_unittest.cc (right):

https://codereview.chromium.org/1290243007/diff/140001/net/spdy/spdy_network_...
net/spdy/spdy_network_transaction_unittest.cc:116: SpdySessionDependencies*
CreateSpdySessionDependencies(
On 2015/08/28 13:38:03, pauljensen wrote:
> would be nice to make this a scoped_ptr too

Done.

https://codereview.chromium.org/1290243007/diff/140001/net/spdy/spdy_network_...
net/spdy/spdy_network_transaction_unittest.cc:4491: 
On 2015/08/28 13:38:02, pauljensen wrote:
> unnecessary whitespace change?

Done.

https://codereview.chromium.org/1290243007/diff/140001/net/spdy/spdy_network_...
net/spdy/spdy_network_transaction_unittest.cc:4588: 
On 2015/08/28 13:38:02, pauljensen wrote:
> ditto

Done.

https://codereview.chromium.org/1290243007/diff/140001/net/spdy/spdy_network_...
net/spdy/spdy_network_transaction_unittest.cc:4590: GetParam(),
ProxyService::CreateFixedFromPacResult("PROXY myproxy:70")));
On 2015/08/28 13:38:02, pauljensen wrote:
> a formatting change...to an unrelated line...perhaps precipitated by the
change
> on line 4588

Moot, since there's now a substantive change on 4589 due to switching
CreateSpdySessionDependencies over to returning a scoped_ptr.

https://codereview.chromium.org/1290243007/diff/140001/net/url_request/url_re...
File net/url_request/url_request_test_util.cc (right):

https://codereview.chromium.org/1290243007/diff/140001/net/url_request/url_re...
net/url_request/url_request_test_util.cc:83: make_scoped_ptr(new
TransportSecurityState));
On 2015/08/28 13:38:03, pauljensen wrote:
> some of these lines have "()" after constructor calls (e.g. line 76, 92) while
> others do not (e.g. lines 83, 85).  perhaps we should make the style
consistent.

So I looked through the beginning of the full patch, and code I didn't touch
goes in different directions on this.  So I'm assuming there's no "one right
way".  Given that, I've somewhat arbitrarily chosen to standardize this function
on having () after constructor calls, and not make any changes elsewhere.  Let
me know if you'd like me to take a different approach.

[Deprecated (see juliatuttle), 2015-09-08 15:39:41]

ttuttle@chromium.org changed reviewers:
+ ttuttle@chromium.org

[Deprecated (see juliatuttle), 2015-09-08 15:39:43]

lgtm with one question:

https://codereview.chromium.org/1290243007/diff/140001/components/data_reduct...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
(right):

https://codereview.chromium.org/1290243007/diff/140001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc:530:
io_data()
Is this what git cl format does? Separating the io_data() and the
->CreateNetworkDelegate seems unnecessary.

https://codereview.chromium.org/1290243007/diff/180001/net/url_request/url_re...
File net/url_request/url_request_test_util.cc (left):

https://codereview.chromium.org/1290243007/diff/180001/net/url_request/url_re...
net/url_request/url_request_test_util.cc:93: if (!transport_security_state()) {
Why was this removed? Was it redundant with the place where it's set above?

[Randy Smith (Not in Mondays), 2015-09-08 16:33:16]

rdsmith@chromium.org changed reviewers:
+ bengr@chromium.org, davidben@chromium.org, dimich@chromium.org,
ellyjones@chromium.org, halliwell@chromium.org, jamescook@chromium.org,
mfoltz@chromium.org, nick@chromium.org, rch@chromium.org, rockot@chromium.org,
sergeyu@chromium.org, sky@chromium.org, stuartmorgan@chromium.org,
torne@chromium.org

[Randy Smith (Not in Mondays), 2015-09-08 16:33:17]

Thanks Thomas!

Time for OWNERS stamps; could the following people PTAL?

bengr@: components/data_reduction_proxy
davidben@: content/
dimich@: google/apis/gcm
ellyjones@: ios/crnet
halliwell@: chromecast/
jamescook@: extensions/shell
mfoltz@: extensions/browser/api/cast_channel
nick@: sync/
rch@: chrome/browser/io_thread.cc
rockot@: device/test/
sergeyu@: remoting/
sky@: mojo/
stuartmorgan@: ios/web
torne@: android_webview

Thanks much!

https://codereview.chromium.org/1290243007/diff/140001/components/data_reduct...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
(right):

https://codereview.chromium.org/1290243007/diff/140001/components/data_reduct...
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc:530:
io_data()
On 2015/09/08 15:39:42, ttuttle wrote:
> Is this what git cl format does? Separating the io_data() and the
> ->CreateNetworkDelegate seems unnecessary.

Yeah, that's git cl format (changed back, re-ran, it corrected me again).  I'll
try to fix it and upload and see if any presubmit stuff objects.  ETA: Nope,
this directory requires using git cl format; I'm afraid that I'm just going to
take whatever it gives me.

https://codereview.chromium.org/1290243007/diff/180001/net/url_request/url_re...
File net/url_request/url_request_test_util.cc (left):

https://codereview.chromium.org/1290243007/diff/180001/net/url_request/url_re...
net/url_request/url_request_test_util.cc:93: if (!transport_security_state()) {
On 2015/09/08 15:39:42, ttuttle wrote:
> Why was this removed? Was it redundant with the place where it's set above?

Yep, AFAICT it's redundant with that setter.

[Torne, 2015-09-08 16:34:36]

android_webview lgtm

[Ken Rockot(use gerrit already), 2015-09-08 16:35:22]

On 2015/09/08 16:33:17, rdsmith wrote:
> Thanks Thomas!
> 
> Time for OWNERS stamps; could the following people PTAL?
> 
> bengr@: components/data_reduction_proxy
> davidben@: content/
> dimich@: google/apis/gcm
> ellyjones@: ios/crnet
> halliwell@: chromecast/
> jamescook@: extensions/shell
> mfoltz@: extensions/browser/api/cast_channel
> nick@: sync/
> rch@: chrome/browser/io_thread.cc
> rockot@: device/test/
> sergeyu@: remoting/
> sky@: mojo/
> stuartmorgan@: ios/web
> torne@: android_webview
> 
> Thanks much!
> 
>
https://codereview.chromium.org/1290243007/diff/140001/components/data_reduct...
> File
>
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
> (right):
> 
>
https://codereview.chromium.org/1290243007/diff/140001/components/data_reduct...
>
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc:530:
> io_data()
> On 2015/09/08 15:39:42, ttuttle wrote:
> > Is this what git cl format does? Separating the io_data() and the
> > ->CreateNetworkDelegate seems unnecessary.
> 
> Yeah, that's git cl format (changed back, re-ran, it corrected me again). 
I'll
> try to fix it and upload and see if any presubmit stuff objects.  ETA: Nope,
> this directory requires using git cl format; I'm afraid that I'm just going to
> take whatever it gives me.
> 
>
https://codereview.chromium.org/1290243007/diff/180001/net/url_request/url_re...
> File net/url_request/url_request_test_util.cc (left):
> 
>
https://codereview.chromium.org/1290243007/diff/180001/net/url_request/url_re...
> net/url_request/url_request_test_util.cc:93: if (!transport_security_state())
{
> On 2015/09/08 15:39:42, ttuttle wrote:
> > Why was this removed? Was it redundant with the place where it's set above?
> 
> Yep, AFAICT it's redundant with that setter.

device/test LGTM

[James Cook, 2015-09-08 16:36:44]

extensions/shell LGTM

[halliwell, 2015-09-08 16:37:38]

On 2015/09/08 16:35:22, Ken Rockot wrote:
> On 2015/09/08 16:33:17, rdsmith wrote:
> > Thanks Thomas!
> > 
> > Time for OWNERS stamps; could the following people PTAL?
> > 
> > bengr@: components/data_reduction_proxy
> > davidben@: content/
> > dimich@: google/apis/gcm
> > ellyjones@: ios/crnet
> > halliwell@: chromecast/
> > jamescook@: extensions/shell
> > mfoltz@: extensions/browser/api/cast_channel
> > nick@: sync/
> > rch@: chrome/browser/io_thread.cc
> > rockot@: device/test/
> > sergeyu@: remoting/
> > sky@: mojo/
> > stuartmorgan@: ios/web
> > torne@: android_webview
> > 
> > Thanks much!
> > 
> >
>
https://codereview.chromium.org/1290243007/diff/140001/components/data_reduct...
> > File
> >
>
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
> > (right):
> > 
> >
>
https://codereview.chromium.org/1290243007/diff/140001/components/data_reduct...
> >
>
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc:530:
> > io_data()
> > On 2015/09/08 15:39:42, ttuttle wrote:
> > > Is this what git cl format does? Separating the io_data() and the
> > > ->CreateNetworkDelegate seems unnecessary.
> > 
> > Yeah, that's git cl format (changed back, re-ran, it corrected me again). 
> I'll
> > try to fix it and upload and see if any presubmit stuff objects.  ETA: Nope,
> > this directory requires using git cl format; I'm afraid that I'm just going
to
> > take whatever it gives me.
> > 
> >
>
https://codereview.chromium.org/1290243007/diff/180001/net/url_request/url_re...
> > File net/url_request/url_request_test_util.cc (left):
> > 
> >
>
https://codereview.chromium.org/1290243007/diff/180001/net/url_request/url_re...
> > net/url_request/url_request_test_util.cc:93: if
(!transport_security_state())
> {
> > On 2015/09/08 15:39:42, ttuttle wrote:
> > > Why was this removed? Was it redundant with the place where it's set
above?
> > 
> > Yep, AFAICT it's redundant with that setter.
> 
> device/test LGTM

chromecast/ lgtm

[ncarter (slow), 2015-09-08 16:43:58]

sync/ and content/ lgtm

[davidben, 2015-09-08 17:02:45]

content lgtm, though it seems nick also covers it.

https://codereview.chromium.org/1290243007/diff/240001/content/shell/browser/...
File content/shell/browser/layout_test/layout_test_url_request_context_getter.cc
(right):

https://codereview.chromium.org/1290243007/diff/240001/content/shell/browser/...
content/shell/browser/layout_test/layout_test_url_request_context_getter.cc:45:
return scoped_ptr<net::ProxyConfigService>();
You can use nullptr here.

https://codereview.chromium.org/1290243007/diff/240001/content/shell/browser/...
File content/shell/browser/shell_url_request_context_getter.cc (right):

https://codereview.chromium.org/1290243007/diff/240001/content/shell/browser/...
content/shell/browser/shell_url_request_context_getter.cc:94: return
make_scoped_ptr(new ShellNetworkDelegate).Pass();
Does it not work without the Pass?

https://codereview.chromium.org/1290243007/diff/240001/content/shell/browser/...
content/shell/browser/shell_url_request_context_getter.cc:207: .Pass());
Ditto.

[Elly Fong-Jones, 2015-09-08 17:03:40]

ios/crnet lgtm

[stuartmorgan, 2015-09-08 17:32:36]

ios/web lgtm

[Ryan Hamilton, 2015-09-08 17:56:14]

chrome/browser/io_thread.cc: LGTM

[bengr, 2015-09-08 18:22:31]

data_reduction_proxy LGTM

[sky, 2015-09-08 20:59:36]

mojo LGTM

[Randy Smith (Not in Mondays), 2015-09-09 16:03:45]

rdsmith@chromium.org changed reviewers:
+ jamiewalch@chromium.org, kmarshall@chromium.org, zea@chromium.org
- dimich@chromium.org, mfoltz@chromium.org, sergeyu@chromium.org

[Randy Smith (Not in Mondays), 2015-09-09 16:03:46]

Thanks all who responded!  Moving on to new reviewers due to lack of response:

kmarshall@: extensions/browser/api/cast_channel
zea@: googl_apis/gcm
jamiewalch@: remoting/

PTAL??

[Jamie, 2015-09-09 17:14:11]

remoting/ LGTM

[Kevin M, 2015-09-09 17:21:02]

lgtm

cast_channel lgtm

[Randy Smith (Not in Mondays), 2015-09-10 17:05:20]

rdsmith@chromium.org changed reviewers:
+ rogerta@chromium.org
- kmarshall@chromium.org, zea@chromium.org

[Randy Smith (Not in Mondays), 2015-09-10 17:05:21]

Thanks very much!  One last review:  

Roger, could you take a look google_apis/*?

[Nicolas Zea, 2015-09-14 17:40:47]

zea@chromium.org changed reviewers:
+ zea@chromium.org

[Nicolas Zea, 2015-09-14 17:40:49]

mcs_probe LGTM

[Roger Tawa OOO till Jul 10th, 2015-09-14 17:42:43]

lgtm google_apis

Sorry for delay.

[Randy Smith (Not in Mondays), 2015-09-14 17:51:42]

Thanks very much!

[Randy Smith (Not in Mondays), 2015-09-14 17:51:52]

The CQ bit was checked by rdsmith@chromium.org

[Randy Smith (Not in Mondays), 2015-09-14 17:51:53]

The patchset sent to the CQ was uploaded after l-g-t-m from ttuttle@chromium.org
Link to the patchset: https://codereview.chromium.org/1290243007/#ps240001
(title: "Sync'd to revision p347709.")

[commit-bot: I haz the power, 2015-09-14 17:53:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1290243007/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1290243007/240001

[commit-bot: I haz the power, 2015-09-14 17:58:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 17:58:04]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Randy Smith (Not in Mondays), 2015-09-16 18:58:12]

The CQ bit was checked by rdsmith@chromium.org

[Randy Smith (Not in Mondays), 2015-09-16 18:58:13]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
jamescook@chromium.org, rogerta@chromium.org, sky@chromium.org,
torne@chromium.org, nick@chromium.org, davidben@chromium.org, rch@chromium.org,
stuartmorgan@chromium.org, ellyjones@chromium.org, halliwell@chromium.org,
ttuttle@chromium.org, bengr@chromium.org, zea@chromium.org,
kmarshall@chromium.org, jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/1290243007/#ps280001
(title: "Sync'd to revision p349162.")

[commit-bot: I haz the power, 2015-09-16 18:59:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1290243007/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1290243007/280001

[commit-bot: I haz the power, 2015-09-16 19:42:16]

Committed patchset #15 (id:280001)

[commit-bot: I haz the power, 2015-09-16 19:43:02]

Patchset 15 (id:??) landed as
https://crrev.com/82957ade8b7a9686c50688ab8caab3a19dcd80b1
Cr-Commit-Position: refs/heads/master@{#349194}

[commit-bot: I haz the power, 2015-09-23 12:59:30]

Patchset 15 (id:??) landed as
https://crrev.com/82957ade8b7a9686c50688ab8caab3a19dcd80b1
Cr-Commit-Position: refs/heads/master@{#349194}