Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Unified Diff: net/proxy/proxy_service.h

Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Paul_BuilderGrab
Patch Set: Sync'd to revision p349162. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_script_fetcher_impl_unittest.cc ('k') | net/proxy/proxy_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_service.h
diff --git a/net/proxy/proxy_service.h b/net/proxy/proxy_service.h
index 76fd4e0799bd3c93ecf890a059e598d7f1bc2d7b..ee74252b1eb9202ce9ce0083f21afd54773efd2a 100644
--- a/net/proxy/proxy_service.h
+++ b/net/proxy/proxy_service.h
@@ -235,32 +235,33 @@ class NET_EXPORT ProxyService : public NetworkChangeNotifier::IPAddressObserver,
// Same as CreateProxyServiceUsingV8ProxyResolver, except it uses system
// libraries for evaluating the PAC script if available, otherwise skips
// proxy autoconfig.
- static ProxyService* CreateUsingSystemProxyResolver(
+ static scoped_ptr<ProxyService> CreateUsingSystemProxyResolver(
ProxyConfigService* proxy_config_service,
size_t num_pac_threads,
NetLog* net_log);
// Creates a ProxyService without support for proxy autoconfig.
- static ProxyService* CreateWithoutProxyResolver(
+ static scoped_ptr<ProxyService> CreateWithoutProxyResolver(
ProxyConfigService* proxy_config_service,
NetLog* net_log);
// Convenience methods that creates a proxy service using the
// specified fixed settings.
- static ProxyService* CreateFixed(const ProxyConfig& pc);
- static ProxyService* CreateFixed(const std::string& proxy);
+ static scoped_ptr<ProxyService> CreateFixed(const ProxyConfig& pc);
+ static scoped_ptr<ProxyService> CreateFixed(const std::string& proxy);
// Creates a proxy service that uses a DIRECT connection for all requests.
- static ProxyService* CreateDirect();
+ static scoped_ptr<ProxyService> CreateDirect();
// |net_log|'s lifetime must exceed ProxyService.
- static ProxyService* CreateDirectWithNetLog(NetLog* net_log);
+ static scoped_ptr<ProxyService> CreateDirectWithNetLog(NetLog* net_log);
// This method is used by tests to create a ProxyService that returns a
// hardcoded proxy fallback list (|pac_string|) for every URL.
//
// |pac_string| is a list of proxy servers, in the format that a PAC script
// would return it. For example, "PROXY foobar:99; SOCKS fml:2; DIRECT"
- static ProxyService* CreateFixedFromPacResult(const std::string& pac_string);
+ static scoped_ptr<ProxyService> CreateFixedFromPacResult(
+ const std::string& pac_string);
// Creates a config service appropriate for this platform that fetches the
// system proxy settings.
« no previous file with comments | « net/proxy/proxy_script_fetcher_impl_unittest.cc ('k') | net/proxy/proxy_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698