components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc - Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Paul_BuilderGrab

Patch Set: Sync'd to revision p349162. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromecast/browser/url_request_context_factory.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

index 8ad2b9c00719d4299d830fd904b634fd36252232..d13f8c49ae2d633d35238e57e61afe1b1011de05 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

@@ -92,11 +92,11 @@ class DataReductionProxyProtocolTest : public testing::Test {

}

// Sets up the |TestURLRequestContext| with the provided |ProxyService|.

- void ConfigureTestDependencies(ProxyService* proxy_service) {

+ void ConfigureTestDependencies(scoped_ptr<ProxyService> proxy_service) {

// Create a context with delayed initialization.

context_.reset(new TestURLRequestContext(true));

- proxy_service_.reset(proxy_service);

+ proxy_service_ = proxy_service.Pass();

context_->set_client_socket_factory(&mock_socket_factory_);

context_->set_proxy_service(proxy_service_.get());

network_delegate_.reset(new net::TestNetworkDelegate());