Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: net/quic/quic_network_transaction_unittest.cc

Issue 1290243007: Shift URLRequestContextStorage over to taking scoped_ptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Paul_BuilderGrab
Patch Set: Sync'd to revision p349162. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_service_v8.cc ('k') | net/quic/test_tools/crypto_test_utils_chromium.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_network_transaction_unittest.cc
diff --git a/net/quic/quic_network_transaction_unittest.cc b/net/quic/quic_network_transaction_unittest.cc
index ffd19182b53a8668766cab7988031ff9a92c49e7..b0b5de27f0abd90d32b3e42686ec88748e2aa5e0 100644
--- a/net/quic/quic_network_transaction_unittest.cc
+++ b/net/quic/quic_network_transaction_unittest.cc
@@ -474,8 +474,7 @@ TEST_P(QuicNetworkTransactionTest, ForceQuic) {
TEST_P(QuicNetworkTransactionTest, QuicProxy) {
params_.enable_insecure_quic = true;
params_.enable_quic_for_proxies = true;
- proxy_service_.reset(
- ProxyService::CreateFixedFromPacResult("QUIC myproxy:70"));
+ proxy_service_ = ProxyService::CreateFixedFromPacResult("QUIC myproxy:70");
MockQuicData mock_quic_data;
mock_quic_data.AddWrite(
@@ -509,8 +508,8 @@ TEST_P(QuicNetworkTransactionTest, QuicProxyWithCert) {
params_.enable_insecure_quic = true;
params_.enable_quic_for_proxies = true;
- proxy_service_.reset(
- ProxyService::CreateFixedFromPacResult("QUIC " + proxy_host + ":70"));
+ proxy_service_ =
+ ProxyService::CreateFixedFromPacResult("QUIC " + proxy_host + ":70");
maker_.set_hostname(origin_host);
MockQuicData mock_quic_data;
@@ -1370,8 +1369,7 @@ TEST_P(QuicNetworkTransactionTest, ZeroRTTWithNoHttpRace) {
TEST_P(QuicNetworkTransactionTest, ZeroRTTWithProxy) {
params_.enable_insecure_quic = true;
- proxy_service_.reset(
- ProxyService::CreateFixedFromPacResult("PROXY myproxy:70"));
+ proxy_service_ = ProxyService::CreateFixedFromPacResult("PROXY myproxy:70");
// Since we are using a proxy, the QUIC job will not succeed.
MockWrite http_writes[] = {
« no previous file with comments | « net/proxy/proxy_service_v8.cc ('k') | net/quic/test_tools/crypto_test_utils_chromium.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698