Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1288893003: [interpreter]: Fix interpreter handler table initialization. (Closed)

Created:
5 years, 4 months ago by rmcilroy
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@interpreter_bytecode_regs
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter]: Fix interpreter handler table initialization. BUG=v8:4280 LOG=N Committed: https://crrev.com/316b1e758b82cc2d06db96a4ef1105ecd50e77b9 Cr-Commit-Position: refs/heads/master@{#30165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/interpreter/interpreter.cc View 2 chunks +1 line, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (4 generated)
rmcilroy
Orion: could you take a look please? Hannes: could you stamp for OWNER/committer (any comments ...
5 years, 4 months ago (2015-08-13 12:29:54 UTC) #2
rmcilroy
To give some background on why this is needed - turns out the builtins aren't ...
5 years, 4 months ago (2015-08-13 12:30:59 UTC) #3
oth
lgtm, thanks!
5 years, 4 months ago (2015-08-13 12:41:07 UTC) #4
rmcilroy
lgtm.
5 years, 4 months ago (2015-08-13 13:59:32 UTC) #5
rmcilroy
On 2015/08/13 13:59:32, rmcilroy wrote: > lgtm. Hannes: could you stamp for OWNERS please?
5 years, 4 months ago (2015-08-13 14:41:56 UTC) #6
Hannes Payer (out of office)
On 2015/08/13 14:41:56, rmcilroy wrote: > On 2015/08/13 13:59:32, rmcilroy wrote: > > lgtm. > ...
5 years, 4 months ago (2015-08-13 16:12:14 UTC) #7
commit-bot: I haz the power
This CL has an open dependency (Issue 1288333002 Patch 1). Please resolve the dependency and ...
5 years, 4 months ago (2015-08-13 16:45:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288893003/1
5 years, 4 months ago (2015-08-13 16:57:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 17:39:26 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 17:39:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/316b1e758b82cc2d06db96a4ef1105ecd50e77b9
Cr-Commit-Position: refs/heads/master@{#30165}

Powered by Google App Engine
This is Rietveld 408576698