Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1288333002: [interpreter]: Update BytecodeArrayBuilder register handling. (Closed)

Created:
5 years, 4 months ago by rmcilroy
Modified:
5 years, 4 months ago
Reviewers:
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter]: Update BytecodeArrayBuilder register handling. Modifies the BytecodeArrayBuilder to create register operands which are negative. This reduces the number of instructions to access registers by the interpreter and allows us to use positive register operands to access parameter values. Adds a Register class to keep register usage typesafe and simplify the convertion to bytecode operand values. BUG=v8:4280 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -160 lines) Patch
M src/interpreter/bytecode-array-builder.h View 6 chunks +34 lines, -10 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 5 chunks +18 lines, -17 lines 0 comments Download
M src/interpreter/bytecodes.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/interpreter/bytecodes.cc View 4 chunks +22 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/interpreter/test-bytecode-array-builder.cc View 1 chunk +0 lines, -112 lines 0 comments Download
A + test/unittests/interpreter/bytecode-array-builder-unittest.cc View 5 chunks +29 lines, -19 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Powered by Google App Engine
This is Rietveld 408576698