Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: src/interpreter/interpreter.cc

Issue 1288893003: [interpreter]: Fix interpreter handler table initialization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@interpreter_bytecode_regs
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/interpreter.cc
diff --git a/src/interpreter/interpreter.cc b/src/interpreter/interpreter.cc
index 50abb0f1a290053782082ad52f0cce149d0876bb..4f961318085e12bbf63f5d336d006ddda14c909d 100644
--- a/src/interpreter/interpreter.cc
+++ b/src/interpreter/interpreter.cc
@@ -31,9 +31,6 @@ Handle<FixedArray> Interpreter::CreateUninitializedInterpreterTable(
// it was allocated on the first page (which is always immovable).
DCHECK(isolate->heap()->old_space()->FirstPage()->Contains(
handler_table->address()));
- for (int i = 0; i < static_cast<int>(Bytecode::kLast); i++) {
- handler_table->set(i, isolate->builtins()->builtin(Builtins::kIllegal));
- }
return handler_table;
}
@@ -62,8 +59,7 @@ void Interpreter::Initialize() {
bool Interpreter::IsInterpreterTableInitialized(
Handle<FixedArray> handler_table) {
DCHECK(handler_table->length() == static_cast<int>(Bytecode::kLast) + 1);
- return handler_table->get(0) ==
- isolate_->builtins()->builtin(Builtins::kIllegal);
+ return handler_table->get(0) != isolate_->heap()->undefined_value();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698