[interpreter]: Changes to interpreter builtins for accumulator and register file registers.

[interpreter]: Changes to interpreter builtins for accumulator and register file registers.

Makes the following modifications to the interpreter builtins and
InterpreterAssembler:
 - Adds an accumulator register and initializes it to undefined()
 - Adds a register file pointer register and use it instead of FramePointer to
   access registers
 - Modifies builtin to support functions with 0 regiters in the register file
 - Modifies builtin to Call rather than TailCall to first bytecode handler.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/00df60d1c6943a10fb5ca84fce2c017dcd2001f5
Cr-Commit-Position: refs/heads/master@{#30219}

[rmcilroy, 2015-08-14 12:08:13]

Patchset #1 (id:1) has been deleted

[rmcilroy, 2015-08-14 12:08:41]

rmcilroy@chromium.org changed reviewers:
+ titzer@chromium.org

[rmcilroy, 2015-08-14 12:08:41]

Ben: Could you take a look please? Thanks.

[rmcilroy, 2015-08-14 12:27:31]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-14 12:27:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1289863003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1289863003/20001

[commit-bot: I haz the power, 2015-08-14 12:27:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-14 12:27:45]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[titzer, 2015-08-14 12:42:20]

https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interprete...
File src/compiler/interpreter-assembler.h (right):

https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interprete...
src/compiler/interpreter-assembler.h:40: Node* IncomingAccumulator();
The distinction between "incoming" accumulator and the "outgoing" accumulator is
somewhat confusing. E.g. it really only makes sense from the perspective of the
user of the assembler. Maybe just "GetAccumulator() and SetAccumulator()", since
the assembler is just holding the current state?

https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interprete...
src/compiler/interpreter-assembler.h:71: Node* RegisterFilePointer();
Can we name this RegisterFileRawPointer() and the one below
BytecodeArrayTaggedPointer() to keep them straight?

[rmcilroy, 2015-08-14 14:02:42]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-14 14:02:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1289863003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1289863003/60001

[rmcilroy, 2015-08-14 14:03:42]

Thanks for the review. Comments addressed, PTAL.

https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interprete...
File src/compiler/interpreter-assembler.h (right):

https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interprete...
src/compiler/interpreter-assembler.h:40: Node* IncomingAccumulator();
On 2015/08/14 12:42:20, titzer wrote:
> The distinction between "incoming" accumulator and the "outgoing" accumulator
is
> somewhat confusing. E.g. it really only makes sense from the perspective of
the
> user of the assembler. Maybe just "GetAccumulator() and SetAccumulator()",
since
> the assembler is just holding the current state?

Good idea. Done.

https://codereview.chromium.org/1289863003/diff/20001/src/compiler/interprete...
src/compiler/interpreter-assembler.h:71: Node* RegisterFilePointer();
On 2015/08/14 12:42:20, titzer wrote:
> Can we name this RegisterFileRawPointer() and the one below
> BytecodeArrayTaggedPointer() to keep them straight?

Done (also done for DispatchTablePointer below)

[commit-bot: I haz the power, 2015-08-14 14:27:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-14 14:27:42]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2015-08-18 08:15:36]

Ping?

[titzer, 2015-08-18 08:59:00]

lgtm

https://codereview.chromium.org/1289863003/diff/60001/src/compiler/interprete...
File src/compiler/interpreter-assembler.h (right):

https://codereview.chromium.org/1289863003/diff/60001/src/compiler/interprete...
src/compiler/interpreter-assembler.h:96: Node* outgoing_accumulator_;
Just "accumulator_"?

[rmcilroy, 2015-08-18 12:04:07]

https://codereview.chromium.org/1289863003/diff/60001/src/compiler/interprete...
File src/compiler/interpreter-assembler.h (right):

https://codereview.chromium.org/1289863003/diff/60001/src/compiler/interprete...
src/compiler/interpreter-assembler.h:96: Node* outgoing_accumulator_;
On 2015/08/18 08:59:00, titzer wrote:
> Just "accumulator_"?

Done.

[rmcilroy, 2015-08-18 12:04:43]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-08-18 12:04:43]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1289863003/#ps80001
(title: "Rename incoming_accumulator")

[commit-bot: I haz the power, 2015-08-18 12:04:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1289863003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1289863003/80001

[commit-bot: I haz the power, 2015-08-18 12:41:46]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-08-18 12:42:09]

Patchset 4 (id:??) landed as
https://crrev.com/00df60d1c6943a10fb5ca84fce2c017dcd2001f5
Cr-Commit-Position: refs/heads/master@{#30219}