Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1288393004: Merge to XFA: Use override in more classes in fpdfsdk/ (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Use override in more classes in fpdfsdk/ R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1287193005 . (cherry picked from commit 0f6b51c0fdd14f5762bf3c7412ac59c825443cc3) Committed: https://pdfium.googlesource.com/pdfium/+/2b1a2d528469cda4e9f3e36d3c7a649e0d476480

Patch Set 1 #

Total comments: 4

Patch Set 2 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1090 lines, -1122 lines) Patch
M core/include/fxge/fx_font.h View 5 chunks +19 lines, -8 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_CheckBox.h View 1 chunk +15 lines, -16 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_FormFiller.h View 1 chunk +25 lines, -24 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_ListBox.h View 1 chunk +20 lines, -24 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_PushButton.h View 1 chunk +10 lines, -10 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_RadioButton.h View 1 chunk +14 lines, -13 lines 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 3 chunks +81 lines, -101 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 1 2 chunks +11 lines, -12 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 chunk +6 lines, -6 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_rendercontext.h View 1 chunk +4 lines, -2 lines 0 comments Download
M fpdfsdk/include/fxedit/fx_edit.h View 3 chunks +5 lines, -3 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_edit.h View 14 chunks +163 lines, -153 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_list.h View 3 chunks +37 lines, -34 lines 0 comments Download
M fpdfsdk/include/javascript/Consts.h View 9 chunks +18 lines, -18 lines 0 comments Download
M fpdfsdk/include/javascript/Document.h View 4 chunks +7 lines, -6 lines 0 comments Download
M fpdfsdk/include/javascript/Field.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/IJavaScript.h View 3 chunks +4 lines, -2 lines 0 comments Download
M fpdfsdk/include/javascript/Icon.h View 2 chunks +4 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Context.h View 2 chunks +103 lines, -113 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Object.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/JS_Runtime.h View 1 chunk +8 lines, -8 lines 0 comments Download
M fpdfsdk/include/javascript/PublicMethods.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/javascript/app.h View 4 chunks +9 lines, -11 lines 0 comments Download
M fpdfsdk/include/javascript/color.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/console.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/event.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/global.h View 2 chunks +5 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/report.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Button.h View 1 chunk +6 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Caret.h View 1 chunk +11 lines, -9 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ComboBox.h View 3 chunks +34 lines, -45 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 2 chunks +38 lines, -44 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_EditCtrl.h View 3 chunks +52 lines, -59 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_FontMap.h View 3 chunks +15 lines, -19 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Icon.h View 2 chunks +5 lines, -4 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_IconList.h View 6 chunks +29 lines, -30 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Label.h View 2 chunks +10 lines, -10 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListBox.h View 2 chunks +35 lines, -33 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListCtrl.h View 2 chunks +5 lines, -4 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Note.h View 9 chunks +108 lines, -118 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ScrollBar.h View 3 chunks +28 lines, -32 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Signature.h View 3 chunks +13 lines, -13 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_SpecialButton.h View 2 chunks +14 lines, -11 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 3 chunks +4 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_dataavail.cpp View 3 chunks +12 lines, -6 lines 0 comments Download
M fpdfsdk/src/fpdf_sysfontinfo.cpp View 4 chunks +18 lines, -18 lines 0 comments Download
M fpdfsdk/src/fpdfsave.cpp View 4 chunks +9 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +37 lines, -54 lines 0 comments Download
M fpdfsdk/src/fsdk_rendercontext.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Object.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/color.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/event.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
TBR https://codereview.chromium.org/1288393004/diff/1/fpdfsdk/include/fsdk_annothandler.h File fpdfsdk/include/fsdk_annothandler.h (right): https://codereview.chromium.org/1288393004/diff/1/fpdfsdk/include/fsdk_annothandler.h#newcode139 fpdfsdk/include/fsdk_annothandler.h:139: CPDFSDK_Annot* NewAnnot(IXFA_Widget* hWidget, This is new. https://codereview.chromium.org/1288393004/diff/1/fpdfsdk/include/fsdk_annothandler.h#newcode213 fpdfsdk/include/fsdk_annothandler.h:213: ...
5 years, 4 months ago (2015-08-15 05:16:14 UTC) #1
Lei Zhang
5 years, 4 months ago (2015-08-15 05:16:28 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
2b1a2d528469cda4e9f3e36d3c7a649e0d476480 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698