Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: fpdfsdk/include/fxedit/fx_edit.h

Issue 1288393004: Merge to XFA: Use override in more classes in fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: self review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/include/fsdk_rendercontext.h ('k') | fpdfsdk/include/fxedit/fxet_edit.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/include/fxedit/fx_edit.h
diff --git a/fpdfsdk/include/fxedit/fx_edit.h b/fpdfsdk/include/fxedit/fx_edit.h
index bfe6a254ff0d2b5788ebdd5d55f7246bd1306256..4f8b2fbd6763d7a75d0bf7e3dd1a404077384585 100644
--- a/fpdfsdk/include/fxedit/fx_edit.h
+++ b/fpdfsdk/include/fxedit/fx_edit.h
@@ -477,12 +477,11 @@ class IFX_Edit {
FX_COLORREF color);
protected:
- ~IFX_Edit() {}
+ virtual ~IFX_Edit() {}
};
class IFX_List_Notify {
public:
- virtual ~IFX_List_Notify() {}
// set the horizontal scrollbar information.
virtual void IOnSetScrollInfoX(FX_FLOAT fPlateMin,
FX_FLOAT fPlateMax,
@@ -503,6 +502,9 @@ class IFX_List_Notify {
virtual void IOnSetScrollPosY(FX_FLOAT fy) = 0;
// Invalidate the rectangle relative to the bounding box of edit.
virtual void IOnInvalidateRect(CPDF_Rect* pRect) = 0;
+
+ protected:
+ virtual ~IFX_List_Notify() {}
};
class IFX_List {
@@ -563,7 +565,7 @@ class IFX_List {
virtual FX_BOOL OnChar(FX_WORD nChar, FX_BOOL bShift, FX_BOOL bCtrl) = 0;
protected:
- ~IFX_List() {}
+ virtual ~IFX_List() {}
};
#endif // FPDFSDK_INCLUDE_FXEDIT_FX_EDIT_H_
« no previous file with comments | « fpdfsdk/include/fsdk_rendercontext.h ('k') | fpdfsdk/include/fxedit/fxet_edit.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698