Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: fpdfsdk/include/fsdk_define.h

Issue 1288393004: Merge to XFA: Use override in more classes in fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: self review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/include/fsdk_baseform.h ('k') | fpdfsdk/include/fsdk_mgr.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/include/fsdk_define.h
diff --git a/fpdfsdk/include/fsdk_define.h b/fpdfsdk/include/fsdk_define.h
index f208c05dab22b5e12da650558583c67f1301cd28..405703656075e1ac7446adb4acc72a4dfc31d585 100644
--- a/fpdfsdk/include/fsdk_define.h
+++ b/fpdfsdk/include/fsdk_define.h
@@ -50,16 +50,16 @@ class IFSDK_PAUSE_Adapter;
class CPDF_CustomAccess final : public IFX_FileRead {
public:
CPDF_CustomAccess(FPDF_FILEACCESS* pFileAccess);
- ~CPDF_CustomAccess() {}
+ ~CPDF_CustomAccess() override {}
+
+ // IFX_FileRead
+ FX_FILESIZE GetSize() override { return m_FileAccess.m_FileLen; }
+ void Release() override { delete this; }
+ FX_BOOL ReadBlock(void* buffer, FX_FILESIZE offset, size_t size) override;
virtual CFX_ByteString GetFullPath() { return ""; }
- virtual FX_FILESIZE GetSize() override { return m_FileAccess.m_FileLen; }
virtual FX_BOOL GetByte(FX_DWORD pos, uint8_t& ch);
virtual FX_BOOL GetBlock(FX_DWORD pos, uint8_t* pBuf, FX_DWORD size);
- virtual void Release() override { delete this; }
- virtual FX_BOOL ReadBlock(void* buffer,
- FX_FILESIZE offset,
- size_t size) override;
FPDF_FILEACCESS m_FileAccess;
uint8_t m_Buffer[512];
« no previous file with comments | « fpdfsdk/include/fsdk_baseform.h ('k') | fpdfsdk/include/fsdk_mgr.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698