Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: fpdfsdk/include/javascript/IJavaScript.h

Issue 1288393004: Merge to XFA: Use override in more classes in fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: self review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/include/javascript/Field.h ('k') | fpdfsdk/include/javascript/Icon.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/include/javascript/IJavaScript.h
diff --git a/fpdfsdk/include/javascript/IJavaScript.h b/fpdfsdk/include/javascript/IJavaScript.h
index d2cbfb1dd8af87bf53a498287fb01657ef1b0ed3..9c232b01fbdf4058854ee91f53b50ee72cc7b18d 100644
--- a/fpdfsdk/include/javascript/IJavaScript.h
+++ b/fpdfsdk/include/javascript/IJavaScript.h
@@ -18,7 +18,6 @@ class CPDFSDK_Document;
class IFXJS_Context {
public:
- virtual ~IFXJS_Context() {}
virtual FX_BOOL Compile(const CFX_WideString& script,
CFX_WideString& info) = 0;
virtual FX_BOOL RunScript(const CFX_WideString& script,
@@ -129,6 +128,9 @@ class IFXJS_Context {
virtual void OnExternal_Exec() = 0;
virtual void EnableMessageBox(FX_BOOL bEnable) = 0;
+
+ protected:
+ virtual ~IFXJS_Context() {}
};
class IFXJS_Runtime {
@@ -147,7 +149,7 @@ class IFXJS_Runtime {
FXJSE_HVALUE hValue) = 0;
protected:
- ~IFXJS_Runtime() {}
+ virtual ~IFXJS_Runtime() {}
};
class CPDFDoc_Environment;
« no previous file with comments | « fpdfsdk/include/javascript/Field.h ('k') | fpdfsdk/include/javascript/Icon.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698