Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1287263005: change asABitmap to isABitmap on shader (Closed)

Created:
5 years, 4 months ago by reed1
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

change asABitmap to isABitmap on shader BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/f5822825ec2d5dd24ab476fdd42db2a6573f9756

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -170 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkShader.h View 3 chunks +13 lines, -24 lines 0 comments Download
M src/core/SkColorShader.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkPictureCommon.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkPictureShader.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
M src/core/SkShader.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 1 chunk +15 lines, -24 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +0 lines, -16 lines 1 comment Download
M src/effects/gradients/SkRadialGradient.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
M src/pdf/SkPDFShader.cpp View 1 2 chunks +3 lines, -5 lines 0 comments Download
M src/utils/SkLua.cpp View 2 chunks +10 lines, -13 lines 0 comments Download
M src/utils/android/SkAndroidSDKCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PictureTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287263005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287263005/1
5 years, 4 months ago (2015-08-19 15:33:23 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/2801) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on ...
5 years, 4 months ago (2015-08-19 15:34:24 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287263005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287263005/20001
5 years, 4 months ago (2015-08-19 17:03:43 UTC) #6
reed1
5 years, 4 months ago (2015-08-19 17:10:42 UTC) #8
reed1
area owners please check that I got the boolean logic correct when we switched from ...
5 years, 4 months ago (2015-08-19 17:11:23 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287263005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287263005/40001
5 years, 4 months ago (2015-08-19 17:11:43 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 17:18:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287263005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287263005/40001
5 years, 4 months ago (2015-08-19 18:45:58 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/f5822825ec2d5dd24ab476fdd42db2a6573f9756
5 years, 4 months ago (2015-08-19 18:46:45 UTC) #17
robertphillips
https://codereview.chromium.org/1287263005/diff/40001/src/effects/gradients/SkLinearGradient.cpp File src/effects/gradients/SkLinearGradient.cpp (left): https://codereview.chromium.org/1287263005/diff/40001/src/effects/gradients/SkLinearGradient.cpp#oldcode263 src/effects/gradients/SkLinearGradient.cpp:263: So we don't care about tracking gradients as bitmaps ...
5 years, 4 months ago (2015-08-19 19:03:02 UTC) #18
reed1
On 2015/08/19 19:03:02, robertphillips wrote: > https://codereview.chromium.org/1287263005/diff/40001/src/effects/gradients/SkLinearGradient.cpp > File src/effects/gradients/SkLinearGradient.cpp (left): > > https://codereview.chromium.org/1287263005/diff/40001/src/effects/gradients/SkLinearGradient.cpp#oldcode263 > ...
5 years, 4 months ago (2015-08-19 19:17:50 UTC) #19
robertphillips
lgtm
5 years, 4 months ago (2015-08-19 19:20:08 UTC) #20
hal.canary
lgtm
5 years, 4 months ago (2015-08-19 21:49:45 UTC) #21
bsalomon
lgtm
5 years, 4 months ago (2015-08-19 22:16:18 UTC) #22
f(malita)
5 years, 4 months ago (2015-08-20 08:45:18 UTC) #23
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698