components/password_manager/core/browser/password_manager.h - Issue 1286593003: [Password Manager] Store forms with field name and id attributes missing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.h

Issue 1286593003: [Password Manager] Store forms with field name and id attributes missing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/password/non_password_form.html ('K') | « components/password_manager/core/browser/password_form_manager_unittest.cc ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.h

diff --git a/components/password_manager/core/browser/password_manager.h b/components/password_manager/core/browser/password_manager.h

index a474d46860eacd5360c722a2014a33aced11de84..0bbdf1e9d9e1effa60ee419651fcd43d595fa793 100644

--- a/components/password_manager/core/browser/password_manager.h

+++ b/components/password_manager/core/browser/password_manager.h

@@ -120,6 +120,10 @@ class PasswordManager : public LoginModel {

PasswordManagerClient* client() { return client_; }

+ // Returns the |pending_login_managers_| count for this form. For non-password

+ // forms this count should be zero.

+ size_t PendingLoginManagersCount() { return pending_login_managers_.size(); }

vivekg 2015/08/14 04:35:16 nit: HasPendingLoginManagerForTesting -> bool

Pritam Nikam 2015/08/14 06:03:42 Done.

private:

enum ProvisionalSaveFailure {

SAVING_DISABLED,