Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 1286593003: [Password Manager] Store forms with field name and id attributes missing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 212e7f10a27b71f046fe25edc018cd371ad6a866..38f048f0a0371caca89e945be108ad864b9cd9a6 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -327,12 +327,6 @@ void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {
return;
}
- // Bail if we're missing any of the necessary form components.
- if (!manager->HasValidPasswordForm()) {
- RecordFailure(INVALID_FORM, form.origin, logger.get());
- return;
- }
-
PasswordForm provisionally_saved_form(form);
provisionally_saved_form.ssl_valid =
form.origin.SchemeIsCryptographic() &&

Powered by Google App Engine
This is Rietveld 408576698