Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: components/password_manager/core/browser/password_manager.h

Issue 1286593003: [Password Manager] Store forms with field name and id attributes missing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 // positive in password saving, update http://crbug.com/357696. 113 // positive in password saving, update http://crbug.com/357696.
114 void OnInPageNavigation(password_manager::PasswordManagerDriver* driver, 114 void OnInPageNavigation(password_manager::PasswordManagerDriver* driver,
115 const autofill::PasswordForm& password_form); 115 const autofill::PasswordForm& password_form);
116 116
117 void ProcessAutofillPredictions( 117 void ProcessAutofillPredictions(
118 password_manager::PasswordManagerDriver* driver, 118 password_manager::PasswordManagerDriver* driver,
119 const std::vector<autofill::FormStructure*>& forms); 119 const std::vector<autofill::FormStructure*>& forms);
120 120
121 PasswordManagerClient* client() { return client_; } 121 PasswordManagerClient* client() { return client_; }
122 122
123 // Returns the |pending_login_managers_| count for this form. For non-password
124 // forms this count should be zero.
125 size_t PendingLoginManagersCount() { return pending_login_managers_.size(); }
vivekg 2015/08/14 04:35:16 nit: HasPendingLoginManagerForTesting -> bool
Pritam Nikam 2015/08/14 06:03:42 Done.
126
123 private: 127 private:
124 enum ProvisionalSaveFailure { 128 enum ProvisionalSaveFailure {
125 SAVING_DISABLED, 129 SAVING_DISABLED,
126 EMPTY_PASSWORD, 130 EMPTY_PASSWORD,
127 NO_MATCHING_FORM, 131 NO_MATCHING_FORM,
128 MATCHING_NOT_COMPLETE, 132 MATCHING_NOT_COMPLETE,
129 FORM_BLACKLISTED, 133 FORM_BLACKLISTED,
130 INVALID_FORM, 134 INVALID_FORM,
131 SYNC_CREDENTIAL, 135 SYNC_CREDENTIAL,
132 MAX_FAILURE_VALUE 136 MAX_FAILURE_VALUE
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 212
209 // The user-visible URL from the last time a password was provisionally saved. 213 // The user-visible URL from the last time a password was provisionally saved.
210 GURL main_frame_url_; 214 GURL main_frame_url_;
211 215
212 DISALLOW_COPY_AND_ASSIGN(PasswordManager); 216 DISALLOW_COPY_AND_ASSIGN(PasswordManager);
213 }; 217 };
214 218
215 } // namespace password_manager 219 } // namespace password_manager
216 220
217 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_ 221 #endif // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698