[Password Manager] Store forms with field name and id attributes missing.

components/password_manager/core/browser/password_form_manager_unittest.cc

Index: components/password_manager/core/browser/password_form_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_form_manager_unittest.cc b/components/password_manager/core/browser/password_form_manager_unittest.cc
index d057f1f099ad6c1a7300a86c79a78f62b59f13a3..7d8c785649cf00bd22844cf062aff0497de3d715 100644
--- a/components/password_manager/core/browser/password_form_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_form_manager_unittest.cc
@@ -754,97 +754,6 @@ TEST_F(PasswordFormManagerTest, TestAlternateUsername) {
   password_store->Shutdown();
 }
 
-TEST_F(PasswordFormManagerTest, TestValidForms) {
-  // User submits credentials for the observed form.
-  PasswordForm credentials = *observed_form();
-  credentials.scheme = PasswordForm::SCHEME_HTML;
-  credentials.username_value = saved_match()->username_value;
-  credentials.password_value = saved_match()->password_value;
-
-  // An alternate version of the form that also has a new_password_element.
-  PasswordForm new_credentials(*observed_form());
-  new_credentials.new_password_element = ASCIIToUTF16("NewPasswd");
-  new_credentials.new_password_value = ASCIIToUTF16("test1new");
-
-  // Form with both username_element and password_element.
-  PasswordFormManager manager1(nullptr, nullptr, kNoDriver, credentials, false);
-  SimulateMatchingPhase(&manager1, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager1.HasValidPasswordForm());
-
-  // Form with username_element, password_element, and new_password_element.
-  PasswordFormManager manager2(nullptr, nullptr, kNoDriver, new_credentials,
-                               false);
-  SimulateMatchingPhase(&manager2, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager2.HasValidPasswordForm());
-
-  // Form with username_element and only new_password_element.
-  new_credentials.password_element.clear();
-  PasswordFormManager manager3(nullptr, nullptr, kNoDriver, new_credentials,
-                               false);
-  SimulateMatchingPhase(&manager3, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager3.HasValidPasswordForm());
-
-  // Form without a username_element but with a password_element.
-  credentials.username_element.clear();
-  PasswordFormManager manager4(nullptr, nullptr, kNoDriver, credentials, false);
-  SimulateMatchingPhase(&manager4, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager4.HasValidPasswordForm());
-
-  // Form without a username_element but with a new_password_element.
-  new_credentials.username_element.clear();
-  PasswordFormManager manager5(nullptr, nullptr, kNoDriver, new_credentials,
-                               false);
-  SimulateMatchingPhase(&manager5, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager5.HasValidPasswordForm());
-
-  // Form without a password_element but with a username_element.
-  credentials.username_element = saved_match()->username_element;
-  credentials.password_element.clear();
-  PasswordFormManager manager6(nullptr, nullptr, kNoDriver, credentials, false);
-  SimulateMatchingPhase(&manager6, RESULT_NO_MATCH);
-  EXPECT_FALSE(manager6.HasValidPasswordForm());
-
-  // Form with neither a password_element nor a username_element.
-  credentials.username_element.clear();
-  credentials.password_element.clear();
-  PasswordFormManager manager7(nullptr, nullptr, kNoDriver, credentials, false);
-  SimulateMatchingPhase(&manager7, RESULT_NO_MATCH);
-  EXPECT_FALSE(manager7.HasValidPasswordForm());
-}
-
-TEST_F(PasswordFormManagerTest, TestValidFormsBasic) {
-  // User submits credentials for the observed form.
-  PasswordForm credentials = *observed_form();
-  credentials.scheme = PasswordForm::SCHEME_BASIC;
-  credentials.username_value = saved_match()->username_value;
-  credentials.password_value = saved_match()->password_value;
-
-  // Form with both username_element and password_element.
-  PasswordFormManager manager1(nullptr, nullptr, kNoDriver, credentials, false);
-  SimulateMatchingPhase(&manager1, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager1.HasValidPasswordForm());
-
-  // Form without a username_element but with a password_element.
-  credentials.username_element.clear();
-  PasswordFormManager manager2(nullptr, nullptr, kNoDriver, credentials, false);
-  SimulateMatchingPhase(&manager2, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager2.HasValidPasswordForm());
-
-  // Form without a password_element but with a username_element.
-  credentials.username_element = saved_match()->username_element;
-  credentials.password_element.clear();
-  PasswordFormManager manager3(nullptr, nullptr, kNoDriver, credentials, false);
-  SimulateMatchingPhase(&manager3, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager3.HasValidPasswordForm());
-
-  // Form with neither a password_element nor a username_element.
-  credentials.username_element.clear();
-  credentials.password_element.clear();
-  PasswordFormManager manager4(nullptr, nullptr, kNoDriver, credentials, false);
-  SimulateMatchingPhase(&manager4, RESULT_NO_MATCH);
-  EXPECT_TRUE(manager4.HasValidPasswordForm());
-}
-
 TEST_F(PasswordFormManagerTest, TestSendNotBlacklistedMessage) {
   TestPasswordManager password_manager(client());
   PasswordFormManager manager_no_creds(