Issue 128653005: [telemetry] Update examples so they work.

Issue 128653005: [telemetry] Update examples so they work. (Closed)

Created:
6 years, 11 months ago by dtu

Modified:
6 years, 11 months ago

Reviewers:
tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[telemetry] Update examples so they work. Change Browser so that entering a with block calls Start(). This better matches the already existing behavior where exiting a with block calls Close(). BUG=None. TEST=tools/telemetry/examples/list_available_browsers; tools/telemetry/examples/telemetry_perf_test.py --browser=system; tools/perf/run_benchmark tab_switching.top_10; tools/perf/run_tests; tools/telemetry/run_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243874

Patch Set 1 #

Patch Set 2 : Fix unit tests that were broken earlier. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -14 lines)			Patch
M	tools/perf/page_sets/PRESUBMIT.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/perf/page_sets/presubmit_unittest.py	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/telemetry/examples/list_available_browsers	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	tools/telemetry/examples/telemetry_perf_test.py	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/core/browser.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/core/extension_unittest.py	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/core/temporary_http_server_unittest.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/unittest/system_stub.py	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

achuithb

I don't think this breaks, right? https://cs.corp.google.com/#chromeos_public/src/third_party/autotest/files/client/common_lib/cros/chrome.py&l=73

6 years, 11 months ago (2014-01-08 23:55:33 UTC) #2

dtu

On 2014/01/08 23:55:33, achuith.bhandarkar wrote: > I don't think this breaks, right? > https://cs.corp.google.com/#chromeos_public/src/third_party/autotest/files/client/common_lib/cros/chrome.py&l=73 Should ...

6 years, 11 months ago (2014-01-09 00:36:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/128653005/20001

6 years, 11 months ago (2014-01-09 00:42:32 UTC) #5

Message was sent while issue was closed.

Change committed as 243874

Expand Messages | Collapse Messages