Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: tools/perf/page_sets/presubmit_unittest.py

Issue 128653005: [telemetry] Update examples so they work. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit tests that were broken earlier. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/PRESUBMIT.py ('k') | tools/telemetry/examples/list_available_browsers » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/presubmit_unittest.py
diff --git a/tools/perf/page_sets/presubmit_unittest.py b/tools/perf/page_sets/presubmit_unittest.py
index c3d3d7ef09813aadb790647aebe40a9dd13ba656..b3d05691839417244f3b999af742c9cce8030148 100644
--- a/tools/perf/page_sets/presubmit_unittest.py
+++ b/tools/perf/page_sets/presubmit_unittest.py
@@ -59,7 +59,8 @@ class PresubmitTest(unittest.TestCase):
success_file_hash = 'da39a3ee5e6b4b0d3255bfef95601890afd80709'
self._stubs = system_stub.Override(
- PRESUBMIT, ['cloud_storage', 'open', 'os'])
+ PRESUBMIT, ['cloud_storage', 'open', 'os', 'raw_input'])
+ self._stubs.raw_input.input = 'public'
# Files in Cloud Storage.
self._stubs.cloud_storage.remote_paths = [
'skip'.zfill(40),
@@ -122,8 +123,7 @@ class PresubmitTest(unittest.TestCase):
def testSkip(self):
results = self._CheckUpload(['/path/to/skip.wpr.sha1'])
- self.assertResultCount(results, 0, 1)
- self.assertTrue('skipping' in str(results[0]), msg=results[0])
+ self.assertResultCount(results, 0, 0)
def testSuccess(self):
results = self._CheckUpload(['/path/to/success.wpr.sha1'])
« no previous file with comments | « tools/perf/page_sets/PRESUBMIT.py ('k') | tools/telemetry/examples/list_available_browsers » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698