tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py - Issue 128653005: [telemetry] Update examples so they work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

Issue 128653005: [telemetry] Update examples so they work. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unit tests that were broken earlier. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

diff --git a/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py b/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

index 2edc586101ee15ef74e2af2a8d892a13e9fc2a99..31c31a233ec1873f288c21be8b487ff7f18c71e8 100644

--- a/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

+++ b/tools/telemetry/telemetry/core/backends/form_based_credentials_backend_unittest_base.py

@@ -36,7 +36,6 @@ class FormBasedCredentialsBackendUnitTestBase(unittest.TestCase):

options = options_for_unittests.GetCopy()

with browser_finder.FindBrowser(options).Create() as b:

- b.Start()

b.credentials.credentials_path = credentials_path

if not b.credentials.CanLogin(self._credentials_type):

return

@@ -54,7 +53,6 @@ class FormBasedCredentialsBackendUnitTestBase(unittest.TestCase):

# Login once to make sure our default profile is logged in.

with browser_finder.FindBrowser(options).Create() as b:

- b.Start()

b.credentials.credentials_path = credentials_path

if not b.credentials.CanLogin(self._credentials_type):

« no previous file with comments | « tools/telemetry/examples/telemetry_perf_test.py ('k') | tools/telemetry/telemetry/core/browser.py » ('j') | no next file with comments »