tools/telemetry/telemetry/core/extension_unittest.py - Issue 128653005: [telemetry] Update examples so they work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/extension_unittest.py

Issue 128653005: [telemetry] Update examples so they work. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unit tests that were broken earlier. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/core/extension_unittest.py

diff --git a/tools/telemetry/telemetry/core/extension_unittest.py b/tools/telemetry/telemetry/core/extension_unittest.py

index 1b330216b121dc5c23ffeaa62836d09c78eab4be..31f1e1b36fb4932b0bac2b81ebd07c223deae9be 100644

--- a/tools/telemetry/telemetry/core/extension_unittest.py

+++ b/tools/telemetry/telemetry/core/extension_unittest.py

@@ -77,7 +77,6 @@ class NonExistentExtensionTest(unittest.TestCase):

extension_path, options.browser_type)

browser_to_create = browser_finder.FindBrowser(options)

with browser_to_create.Create() as b:

- b.Start()

if b.supports_extensions:

self.assertRaises(extension_dict_backend.ExtensionNotFoundException,

lambda: b.extensions[load_extension])

@@ -149,7 +148,6 @@ class ComponentExtensionTest(unittest.TestCase):

return

with browser_to_create.Create() as b:

- b.Start()

extension = b.extensions[load_extension]

self.assertTrue(

extension.EvaluateJavaScript('chrome.runtime != null'))