Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1286343003: DevTools: make InspectorDebuggerAgent aggregate V8DebuggerAgent instead of inheriting (Closed)

Created:
5 years, 4 months ago by yurys
Modified:
5 years, 4 months ago
Reviewers:
dgozman, sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, pfeldman+blink_chromium.org, vivekg_samsung, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vivekg, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, blink-reviews-bindings_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: make InspectorDebuggerAgent aggregate V8DebuggerAgent instead of inheriting InspectorDebuggerAgent now implements V8DebuggerAgent::Client and aggregates V8DebuggerAgent. The latter will be moved into a reusable component which cannot depend on Blink. BUG=439376 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200678

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixed presubmit errors #

Total comments: 2

Patch Set 3 : Addressed dgozman's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+414 lines, -121 lines) Patch
M Source/bindings/core/v8/ScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/AsyncCallTracker.h View 3 chunks +5 lines, -6 lines 0 comments Download
M Source/core/inspector/AsyncCallTracker.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M Source/core/inspector/InjectedScriptHost.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InjectedScriptHost.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorBaseAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.h View 6 chunks +5 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 2 1 chunk +61 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 2 3 chunks +259 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.cpp View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/V8DebuggerAgent.h View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/inspector/V8DebuggerAgent.cpp View 1 2 15 chunks +29 lines, -52 lines 0 comments Download
M Source/core/inspector/WorkerDebuggerAgent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
yurys
5 years, 4 months ago (2015-08-15 00:45:32 UTC) #2
dgozman
lgtm with nits https://codereview.chromium.org/1286343003/diff/1/Source/core/inspector/InspectorDebuggerAgent.h File Source/core/inspector/InspectorDebuggerAgent.h (right): https://codereview.chromium.org/1286343003/diff/1/Source/core/inspector/InspectorDebuggerAgent.h#newcode46 Source/core/inspector/InspectorDebuggerAgent.h:46: // Protocol implementation We usually write ...
5 years, 4 months ago (2015-08-15 01:05:56 UTC) #3
yurys
https://codereview.chromium.org/1286343003/diff/1/Source/core/inspector/InspectorDebuggerAgent.h File Source/core/inspector/InspectorDebuggerAgent.h (right): https://codereview.chromium.org/1286343003/diff/1/Source/core/inspector/InspectorDebuggerAgent.h#newcode46 Source/core/inspector/InspectorDebuggerAgent.h:46: // Protocol implementation On 2015/08/15 01:05:56, dgozman wrote: > ...
5 years, 4 months ago (2015-08-17 17:15:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286343003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286343003/40001
5 years, 4 months ago (2015-08-17 17:15:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99071)
5 years, 4 months ago (2015-08-17 20:09:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286343003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286343003/40001
5 years, 4 months ago (2015-08-17 21:29:49 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 22:56:19 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200678

Powered by Google App Engine
This is Rietveld 408576698