Source/core/inspector/InspectorInstrumentation.idl - Issue 1286343003: DevTools: make InspectorDebuggerAgent aggregate V8DebuggerAgent instead of inheriting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorInstrumentation.idl

Issue 1286343003: DevTools: make InspectorDebuggerAgent aggregate V8DebuggerAgent instead of inheriting (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed dgozman's comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/inspector/InspectorInstrumentation.idl

diff --git a/Source/core/inspector/InspectorInstrumentation.idl b/Source/core/inspector/InspectorInstrumentation.idl

index ebff07d322704352c13faf87ff0b162b7930b53d..f9cd5af6c6f15dbd2af2e205b7c77a56efab6096 100644

--- a/Source/core/inspector/InspectorInstrumentation.idl

+++ b/Source/core/inspector/InspectorInstrumentation.idl

@@ -138,7 +138,7 @@ interface InspectorInstrumentation {

void didRemoveTimer([Keep] ExecutionContext*, int timerId);

[Debugger, Inline=FastReturn]

- InspectorInstrumentationCookie willCallFunction([Keep] ExecutionContext*, const DevToolsFunctionInfo&);

+ InspectorInstrumentationCookie willCallFunction(ExecutionContext*, const DevToolsFunctionInfo&);

[Debugger, Inline=FastReturn]

void didCallFunction(const InspectorInstrumentationCookie&);

@@ -180,7 +180,7 @@ interface InspectorInstrumentation {

void didPerformExecutionContextTask(ExecutionContext*);

[Debugger, DOMDebugger, Inline=FastReturn]

- InspectorInstrumentationCookie willEvaluateScript(LocalFrame*, const String& url, int lineNumber);

+ InspectorInstrumentationCookie willEvaluateScript(LocalFrame*);

[Debugger, Inline=FastReturn]

void didEvaluateScript(const InspectorInstrumentationCookie&);

« no previous file with comments | « Source/core/inspector/InspectorDebuggerAgent.cpp ('k') | Source/core/inspector/PageDebuggerAgent.cpp » ('j') | no next file with comments »