Source/bindings/core/v8/ScriptController.cpp - Issue 1286343003: DevTools: make InspectorDebuggerAgent aggregate V8DebuggerAgent instead of inheriting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptController.cpp

Issue 1286343003: DevTools: make InspectorDebuggerAgent aggregate V8DebuggerAgent instead of inheriting (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed dgozman's comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/ScriptController.cpp

diff --git a/Source/bindings/core/v8/ScriptController.cpp b/Source/bindings/core/v8/ScriptController.cpp

index 5d83c19193a4604e0ed937ebc9c85dabecb344b3..59a1ed877cd3dbde3c3ccc0278b2f9b515c29283 100644

--- a/Source/bindings/core/v8/ScriptController.cpp

+++ b/Source/bindings/core/v8/ScriptController.cpp

@@ -160,7 +160,7 @@ v8::MaybeLocal<v8::Value> ScriptController::callFunction(ExecutionContext* conte

v8::Local<v8::Value> ScriptController::executeScriptAndReturnValue(v8::Local<v8::Context> context, const ScriptSourceCode& source, AccessControlStatus accessControlStatus, double* compilationFinishTime)

{

TRACE_EVENT1("devtools.timeline", "EvaluateScript", "data", InspectorEvaluateScriptEvent::data(frame(), source.url().string(), source.startLine()));

- InspectorInstrumentationCookie cookie = InspectorInstrumentation::willEvaluateScript(frame(), source.url().string(), source.startLine());

+ InspectorInstrumentationCookie cookie = InspectorInstrumentation::willEvaluateScript(frame());

v8::Local<v8::Value> result;

{

« no previous file with comments | « no previous file | Source/core/inspector/AsyncCallTracker.h » ('j') | no next file with comments »