Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: Source/core/inspector/InspectorDOMDebuggerAgent.h

Issue 1286343003: DevTools: make InspectorDebuggerAgent aggregate V8DebuggerAgent instead of inheriting (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressed dgozman's comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorDOMDebuggerAgent.h
diff --git a/Source/core/inspector/InspectorDOMDebuggerAgent.h b/Source/core/inspector/InspectorDOMDebuggerAgent.h
index db1982e6ca912de24d761b321eeb4f350a4799c9..73600bbf84e25b5594be913eb48424f93dacc141 100644
--- a/Source/core/inspector/InspectorDOMDebuggerAgent.h
+++ b/Source/core/inspector/InspectorDOMDebuggerAgent.h
@@ -35,7 +35,6 @@
#include "core/CoreExport.h"
#include "core/inspector/InspectorBaseAgent.h"
#include "core/inspector/InspectorDOMAgent.h"
-#include "core/inspector/InspectorDebuggerAgent.h"
#include "wtf/HashMap.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/text/WTFString.h"
@@ -47,11 +46,11 @@ class Event;
class EventListener;
class EventTarget;
class InjectedScriptManager;
-class InspectorDebuggerAgent;
class InspectorDOMAgent;
class JSONObject;
class Node;
class RegisteredEventListener;
+class V8DebuggerAgent;
typedef String ErrorString;
@@ -60,7 +59,7 @@ class CORE_EXPORT InspectorDOMDebuggerAgent final
, public InspectorBackendDispatcher::DOMDebuggerCommandHandler {
WTF_MAKE_NONCOPYABLE(InspectorDOMDebuggerAgent);
public:
- static PassOwnPtrWillBeRawPtr<InspectorDOMDebuggerAgent> create(InjectedScriptManager*, InspectorDOMAgent*, InspectorDebuggerAgent*);
+ static PassOwnPtrWillBeRawPtr<InspectorDOMDebuggerAgent> create(InjectedScriptManager*, InspectorDOMAgent*, V8DebuggerAgent*);
~InspectorDOMDebuggerAgent() override;
DECLARE_VIRTUAL_TRACE();
@@ -91,7 +90,7 @@ public:
void didCancelAnimationFrame(ExecutionContext*, int callbackId);
void willFireAnimationFrame(ExecutionContext*, int callbackId);
void willHandleEvent(EventTarget*, Event*, EventListener*, bool useCapture);
- void willEvaluateScript(const String& url, int lineNumber);
+ void willEvaluateScript();
void didFireWebGLError(const String& errorName);
void didFireWebGLWarning();
void didFireWebGLErrorOrWarning(const String& message);
@@ -101,7 +100,7 @@ public:
void restore() override;
private:
- InspectorDOMDebuggerAgent(InjectedScriptManager*, InspectorDOMAgent*, InspectorDebuggerAgent*);
+ InspectorDOMDebuggerAgent(InjectedScriptManager*, InspectorDOMAgent*, V8DebuggerAgent*);
void pauseOnNativeEventIfNeeded(PassRefPtr<JSONObject> eventData, bool synchronous);
PassRefPtr<JSONObject> preparePauseOnNativeEventData(const String& eventName, const String* targetName);
@@ -121,7 +120,7 @@ private:
RawPtrWillBeMember<InjectedScriptManager> m_injectedScriptManager;
RawPtrWillBeMember<InspectorDOMAgent> m_domAgent;
- RawPtrWillBeMember<InspectorDebuggerAgent> m_debuggerAgent;
+ RawPtrWillBeMember<V8DebuggerAgent> m_debuggerAgent;
WillBeHeapHashMap<RawPtrWillBeMember<Node>, uint32_t> m_domBreakpoints;
};
« no previous file with comments | « Source/core/inspector/InspectorConsoleAgent.cpp ('k') | Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698