Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1285413007: Unify geometry test printers in a test support target. (Closed)

Created:
5 years, 4 months ago by jbroman
Modified:
5 years, 4 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Unify geometry test printers in a test support target. This adds a new target which provides test support for Source/platform/. These can be used in platform unit tests, or unit tests of targets which depend on platform. GYP: blink_platform_test_support (static_library) GN: //third_party/WebKit/Source/platform:test_support (source_set) Existing GTest print support for Source/platform/geometry/ types has been made more consistent, and moved into this target. Both blink_platform_unittests and webkit_unit_tests depend on it. To avoid ODR violations, the declarations of these are in the headers of the types that are being printed. If these are called outside unit tests, a link error will occur. This is similar to how ui/gfx/ does things in Chromium; it's seems like a more reasonable approach than what we do today. BUG=522198 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200933

Patch Set 1 #

Patch Set 2 : PrintTo instead of operator<< #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -165 lines) Patch
M Source/core/layout/OverflowModelTest.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M Source/platform/BUILD.gn View 2 chunks +16 lines, -0 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/platform/blink_platform_tests.gyp View 2 chunks +15 lines, -0 lines 0 comments Download
M Source/platform/geometry/FloatBox.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M Source/platform/geometry/FloatBoxTestHelpers.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/geometry/FloatBoxTestHelpers.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/platform/geometry/FloatPoint.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M Source/platform/geometry/FloatQuad.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M Source/platform/geometry/FloatRect.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M Source/platform/geometry/FloatRoundedRect.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M Source/platform/geometry/FloatRoundedRectTest.cpp View 1 chunk +0 lines, -32 lines 0 comments Download
M Source/platform/geometry/FloatSize.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M Source/platform/geometry/LayoutRect.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M Source/platform/platform.gni View 1 chunk +1 line, -0 lines 0 comments Download
A Source/platform/testing/GeometryPrinters.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
A Source/platform/testing/GeometryPrinters.cpp View 1 1 chunk +122 lines, -0 lines 0 comments Download
M Source/web/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
D Source/web/tests/FloatPointTestHelpers.h View 1 chunk +0 lines, -50 lines 0 comments Download
D Source/web/tests/FloatQuadTestHelpers.h View 1 chunk +0 lines, -53 lines 0 comments Download
M Source/web/tests/LayoutGeometryMapTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/web.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/web_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbroman
Not urgent, but I was getting annoyed with geometry types being described as "32-byte object ...
5 years, 4 months ago (2015-08-19 15:02:50 UTC) #2
pdr.
LGTM
5 years, 4 months ago (2015-08-20 07:11:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285413007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285413007/20001
5 years, 4 months ago (2015-08-20 15:15:39 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 20:30:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200933

Powered by Google App Engine
This is Rietveld 408576698