|
Unify geometry test printers in a test support target.
This adds a new target which provides test support for Source/platform/.
These can be used in platform unit tests, or unit tests of targets which
depend on platform.
GYP: blink_platform_test_support (static_library)
GN: //third_party/WebKit/Source/platform:test_support (source_set)
Existing GTest print support for Source/platform/geometry/ types has been
made more consistent, and moved into this target. Both
blink_platform_unittests and webkit_unit_tests depend on it.
To avoid ODR violations, the declarations of these are in the headers
of the types that are being printed. If these are called outside unit tests,
a link error will occur.
This is similar to how ui/gfx/ does things in Chromium; it's seems like
a more reasonable approach than what we do today.
BUG= 522198
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200933
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+243 lines, -165 lines) |
Patch |
 |
M |
Source/core/layout/OverflowModelTest.cpp
|
View
|
|
2 chunks |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
M |
Source/platform/BUILD.gn
|
View
|
|
2 chunks |
+16 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/platform/blink_platform.gypi
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/platform/blink_platform_tests.gyp
|
View
|
|
2 chunks |
+15 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/platform/geometry/FloatBox.h
|
View
|
1
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/platform/geometry/FloatBoxTestHelpers.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/platform/geometry/FloatBoxTestHelpers.cpp
|
View
|
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
M |
Source/platform/geometry/FloatPoint.h
|
View
|
1
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/platform/geometry/FloatQuad.h
|
View
|
1
|
2 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/platform/geometry/FloatRect.h
|
View
|
1
|
2 chunks |
+6 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/platform/geometry/FloatRoundedRect.h
|
View
|
1
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/platform/geometry/FloatRoundedRectTest.cpp
|
View
|
|
1 chunk |
+0 lines, -32 lines |
0 comments
|
Download
|
 |
M |
Source/platform/geometry/FloatSize.h
|
View
|
1
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/platform/geometry/LayoutRect.h
|
View
|
1
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/platform/platform.gni
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
A |
Source/platform/testing/GeometryPrinters.h
|
View
|
1
|
1 chunk |
+42 lines, -0 lines |
0 comments
|
Download
|
 |
A |
Source/platform/testing/GeometryPrinters.cpp
|
View
|
1
|
1 chunk |
+122 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/web/BUILD.gn
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
D |
Source/web/tests/FloatPointTestHelpers.h
|
View
|
|
1 chunk |
+0 lines, -50 lines |
0 comments
|
Download
|
 |
D |
Source/web/tests/FloatQuadTestHelpers.h
|
View
|
|
1 chunk |
+0 lines, -53 lines |
0 comments
|
Download
|
 |
M |
Source/web/tests/LayoutGeometryMapTest.cpp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/web/web.gyp
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
Source/web/web_tests.gyp
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|