Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1284803004: Remove a superfluous <li> wrapper on chrome://extensions (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a superfluous <li> wrapper on chrome://extensions R=hcarmona@chromium.org BUG=518053 Committed: https://crrev.com/652ecf6da8243ce6b526d839ec0acc4a158259ef Cr-Commit-Position: refs/heads/master@{#342797}

Patch Set 1 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/resources/extensions/extension_error.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/extensions/extension_error.js View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Issue 1283013003 Patch 1

Dependent Patchsets:

Issue 1281483008 Patch 40001

Messages

Total messages: 10 (4 generated)
Dan Beam
5 years, 4 months ago (2015-08-11 01:00:00 UTC) #3
Dan Beam
-kalman@, +hcarmona@ as this is pretty trivial and only dev/canary channel users see this [kinda ...
5 years, 4 months ago (2015-08-11 01:32:23 UTC) #5
hcarmona
lgtm
5 years, 4 months ago (2015-08-11 01:52:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1284803004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1284803004/20001
5 years, 4 months ago (2015-08-11 07:15:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 4 months ago (2015-08-11 08:00:51 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 08:01:39 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/652ecf6da8243ce6b526d839ec0acc4a158259ef
Cr-Commit-Position: refs/heads/master@{#342797}

Powered by Google App Engine
This is Rietveld 408576698