chrome/browser/resources/extensions/extension_error.js - Issue 1284803004: Remove a superfluous <li> wrapper on chrome://extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_error.js

Issue 1284803004: Remove a superfluous <li> wrapper on chrome://extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/extensions/extension_error.js

diff --git a/chrome/browser/resources/extensions/extension_error.js b/chrome/browser/resources/extensions/extension_error.js

index ef117c15dd1d84c19e04e21ea810ee3926b673b4..ab66f77d3fbd6103118dcd364738a65378a631fe 100644

--- a/chrome/browser/resources/extensions/extension_error.js

+++ b/chrome/browser/resources/extensions/extension_error.js

@@ -229,8 +229,7 @@ cr.define('extensions', function() {

this.querySelector('#no-errors-span').hidden = true;

this.errors_.push(error);

var focusRow = new ExtensionError(error, this.listContents_);

- this.listContents_.appendChild(document.createElement('li')).

- appendChild(focusRow);

+ this.listContents_.appendChild(focusRow);

this.focusGrid_.addRow(focusRow);

« no previous file with comments | « chrome/browser/resources/extensions/extension_error.html ('k') | no next file » | no next file with comments »