Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1281483008: Move downloads.FocusRow.shouldFocus to cr.ui.FocusRow.isFocusable (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@focus-row2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move downloads.FocusRow.shouldFocus to cr.ui.FocusRow.isFocusable There's nothing downloads-specific about this code and I'd like to use it in other places. R=hcarmona@chromium.org BUG=425626, 518053 Committed: https://crrev.com/f11259add744e6b6355810f3b2f53dcd8cb1d979 Cr-Commit-Position: refs/heads/master@{#342836}

Patch Set 1 : whoops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -22 lines) Patch
M chrome/browser/resources/downloads/focus_row.js View 2 chunks +1 line, -20 lines 0 comments Download
M chrome/browser/resources/downloads/manager.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/webui/resources/js/cr/ui/focus_row.js View 1 chunk +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1284803004 Patch 20001

Dependent Patchsets:

Issue 1273033004 Patch 1

Messages

Total messages: 8 (3 generated)
Dan Beam
5 years, 4 months ago (2015-08-11 01:28:28 UTC) #3
hcarmona
lgtm
5 years, 4 months ago (2015-08-11 02:05:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1281483008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1281483008/40001
5 years, 4 months ago (2015-08-11 15:20:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 4 months ago (2015-08-11 17:30:37 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 17:31:29 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f11259add744e6b6355810f3b2f53dcd8cb1d979
Cr-Commit-Position: refs/heads/master@{#342836}

Powered by Google App Engine
This is Rietveld 408576698