Issue 1283013003: Rename gridBoundary_ to listContents_.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1283013003: Rename gridBoundary_ to listContents_. (Closed)

Created:
5 years, 4 months ago by Dan Beam

Modified:
5 years, 4 months ago

Reviewers:
hcarmona

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@focus-row0

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Rename gridBoundary_ to listContents_. This is so my cr.ui.FocusRow refactor is easier to review. R=hcarmona@chromium.org BUG=518053 Committed: https://crrev.com/22c227a2fa178a616044a483539089aedbb96784 Cr-Commit-Position: refs/heads/master@{#342787}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	chrome/browser/resources/extensions/extension_error.js	View		4 chunks	+7 lines, -7 lines	0 comments	Download

Depends on Patchset:

Issue 1277833003 Patch 1

Dependent Patchsets:

Issue 1284803004 Patch 20001

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283013003/1

5 years, 4 months ago (2015-08-11 03:11:38 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-11 04:20:34 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/22c227a2fa178a616044a483539089aedbb96784
Cr-Commit-Position: refs/heads/master@{#342787}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages