Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1277833003: Re-use local variable instead of querySelector()ing it again (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-use local variable instead of querySelector()ing it again R=hcarmona@chromium.org BUG=518053 Committed: https://crrev.com/19456822c60beed368966ca9f6f3f6d199db233a Cr-Commit-Position: refs/heads/master@{#342782}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/extensions/extension_error.js View 1 chunk +1 line, -1 line 3 comments Download

Dependent Patchsets:

Issue 1283013003 Patch 1

Messages

Total messages: 11 (3 generated)
Dan Beam
https://codereview.chromium.org/1277833003/diff/1/chrome/browser/resources/extensions/extension_error.js File chrome/browser/resources/extensions/extension_error.js (right): https://codereview.chromium.org/1277833003/diff/1/chrome/browser/resources/extensions/extension_error.js#newcode117 chrome/browser/resources/extensions/extension_error.js:117: var deleteButton = this.querySelector('.error-delete-button'); ^
5 years, 4 months ago (2015-08-11 00:48:56 UTC) #1
hcarmona
https://codereview.chromium.org/1277833003/diff/1/chrome/browser/resources/extensions/extension_error.js File chrome/browser/resources/extensions/extension_error.js (right): https://codereview.chromium.org/1277833003/diff/1/chrome/browser/resources/extensions/extension_error.js#newcode134 chrome/browser/resources/extensions/extension_error.js:134: this.addFocusableElement(deleteButton); I'm curious how this behaves because |this| and ...
5 years, 4 months ago (2015-08-11 01:39:35 UTC) #2
Dan Beam
https://codereview.chromium.org/1277833003/diff/1/chrome/browser/resources/extensions/extension_error.js File chrome/browser/resources/extensions/extension_error.js (right): https://codereview.chromium.org/1277833003/diff/1/chrome/browser/resources/extensions/extension_error.js#newcode134 chrome/browser/resources/extensions/extension_error.js:134: this.addFocusableElement(deleteButton); On 2015/08/11 01:39:35, Hector Carmona wrote: > I'm ...
5 years, 4 months ago (2015-08-11 01:41:55 UTC) #3
hcarmona
lgtm
5 years, 4 months ago (2015-08-11 01:45:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277833003/1
5 years, 4 months ago (2015-08-11 01:47:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277833003/1
5 years, 4 months ago (2015-08-11 03:03:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 03:08:45 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 03:09:31 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/19456822c60beed368966ca9f6f3f6d199db233a
Cr-Commit-Position: refs/heads/master@{#342782}

Powered by Google App Engine
This is Rietveld 408576698