Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4146)

Unified Diff: chrome/browser/resources/extensions/extension_error.js

Issue 1283013003: Rename gridBoundary_ to listContents_. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@focus-row0
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/extensions/extension_error.js
diff --git a/chrome/browser/resources/extensions/extension_error.js b/chrome/browser/resources/extensions/extension_error.js
index fbf4d77b4c2a3fc70583f9ea6ec52f2af7fcaec6..ef117c15dd1d84c19e04e21ea810ee3926b673b4 100644
--- a/chrome/browser/resources/extensions/extension_error.js
+++ b/chrome/browser/resources/extensions/extension_error.js
@@ -175,9 +175,9 @@ cr.define('extensions', function() {
this.errors_ = [];
this.focusGrid_ = new cr.ui.FocusGrid();
- this.gridBoundary_ = this.querySelector('.extension-error-list-contents');
- this.gridBoundary_.addEventListener('focus', this.onFocus_.bind(this));
- this.gridBoundary_.addEventListener('focusin',
+ this.listContents_ = this.querySelector('.extension-error-list-contents');
+ this.listContents_.addEventListener('focus', this.onFocus_.bind(this));
+ this.listContents_.addEventListener('focusin',
this.onFocusin_.bind(this));
errors.forEach(this.addError_, this);
@@ -228,8 +228,8 @@ cr.define('extensions', function() {
addError_: function(error) {
this.querySelector('#no-errors-span').hidden = true;
this.errors_.push(error);
- var focusRow = new ExtensionError(error, this.gridBoundary_);
- this.gridBoundary_.appendChild(document.createElement('li')).
+ var focusRow = new ExtensionError(error, this.listContents_);
+ this.listContents_.appendChild(document.createElement('li')).
appendChild(focusRow);
this.focusGrid_.addRow(focusRow);
},
@@ -364,7 +364,7 @@ cr.define('extensions', function() {
* @private
*/
onFocusin_: function() {
- this.gridBoundary_.tabIndex = -1;
+ this.listContents_.tabIndex = -1;
},
/**
@@ -373,7 +373,7 @@ cr.define('extensions', function() {
* @private
*/
onFocus_: function() {
- var activeRow = this.gridBoundary_.querySelector('.focus-row-active');
+ var activeRow = this.listContents_.querySelector('.focus-row-active');
activeRow.getEquivalentElement(null).focus();
},
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698