chrome/browser/resources/downloads/manager.js - Issue 1281483008: Move downloads.FocusRow.shouldFocus to cr.ui.FocusRow.isFocusable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/downloads/manager.js

Issue 1281483008: Move downloads.FocusRow.shouldFocus to cr.ui.FocusRow.isFocusable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@focus-row2

Patch Set: whoops Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/downloads/manager.js

diff --git a/chrome/browser/resources/downloads/manager.js b/chrome/browser/resources/downloads/manager.js

index e7c01e220d84cb7feffabfc35d63fd0475e20727..a11d8496ae57baf90710d21d954badc31fe7fd8c 100644

--- a/chrome/browser/resources/downloads/manager.js

+++ b/chrome/browser/resources/downloads/manager.js

@@ -133,7 +133,7 @@ cr.define('downloads', function() {

var focusRow = this.decorateItem_(item);

if (focusRow.contains(activeElement) &&

- !downloads.FocusRow.shouldFocus(activeElement)) {

+ !cr.ui.FocusRow.isFocusable(activeElement)) {

focusRow.getEquivalentElement(activeElement).focus();

}

@@ -154,7 +154,7 @@ cr.define('downloads', function() {

this.focusGrid_.addRow(focusRow);

if (focusRow.contains(activeElement) &&

- !downloads.FocusRow.shouldFocus(activeElement)) {

+ !cr.ui.FocusRow.isFocusable(activeElement)) {

focusRow.getEquivalentElement(activeElement).focus();

}

}, this);

« no previous file with comments | « chrome/browser/resources/downloads/focus_row.js ('k') | ui/webui/resources/js/cr/ui/focus_row.js » ('j') | no next file with comments »