Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1273033004: Remove focus event listeners from un-focusable node (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@focus-row3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove focus event listeners from un-focusable node This UI used to live in a world where its <ul> element had a tabindex=0 or something. No longer. R=hcarmona@chromium.org BUG=518053 Committed: https://crrev.com/183d87c0c20d5bea0fb40378c4437a811c63f7da Cr-Commit-Position: refs/heads/master@{#342855}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
M chrome/browser/resources/extensions/extension_error.js View 2 chunks +1 line, -22 lines 3 comments Download

Depends on Patchset:

Issue 1281483008 Patch 40001

Dependent Patchsets:

Issue 1275363003 Patch 20001
Issue 1275363003 Patch 60001

Messages

Total messages: 6 (1 generated)
Dan Beam
https://codereview.chromium.org/1273033004/diff/1/chrome/browser/resources/extensions/extension_error.js File chrome/browser/resources/extensions/extension_error.js (left): https://codereview.chromium.org/1273033004/diff/1/chrome/browser/resources/extensions/extension_error.js#oldcode376 chrome/browser/resources/extensions/extension_error.js:376: activeRow.getEquivalentElement(null).focus(); had this code ever worked, this would blow ...
5 years, 4 months ago (2015-08-11 01:36:21 UTC) #1
hcarmona
lgtm https://codereview.chromium.org/1273033004/diff/1/chrome/browser/resources/extensions/extension_error.js File chrome/browser/resources/extensions/extension_error.js (left): https://codereview.chromium.org/1273033004/diff/1/chrome/browser/resources/extensions/extension_error.js#oldcode376 chrome/browser/resources/extensions/extension_error.js:376: activeRow.getEquivalentElement(null).focus(); On 2015/08/11 01:36:21, Dan Beam wrote: > ...
5 years, 4 months ago (2015-08-11 02:03:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273033004/1
5 years, 4 months ago (2015-08-11 17:43:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 18:50:38 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 18:51:38 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/183d87c0c20d5bea0fb40378c4437a811c63f7da
Cr-Commit-Position: refs/heads/master@{#342855}

Powered by Google App Engine
This is Rietveld 408576698