Forward "include_dirs" to executable target in "ios_app" template.

Forward "include_dirs" to executable target in "ios_app" template.

Many unit tests targets sets "include_dirs" variable. As the "test"
template uses "ios_app" on iOS, the content needs to be forwarded
to the "executable" target since it is the one doing the compilation.

Fixes the following error when running "gn gen" for iOS after adding
//net:net_unittests to the list of targets in //BUILD.gn:

ERROR at //ui/events/BUILD.gn:360:18: Assignment had no effect.
  include_dirs = [ "//testing/gmock/include" ]
                 ^---------------------------
You set the variable "include_dirs" here and it was unused before it went
out of scope.

BUG=459705
Committed: https://crrev.com/66ccebf75ce1139adeec700b036bf9332d2b177f
Cr-Commit-Position: refs/heads/master@{#342596}

[sdefresne, 2015-08-07 17:18:22]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org, sherouk@google.com

[sdefresne, 2015-08-07 17:18:22]

dpranke/brettw: please take a look.

[brettw, 2015-08-07 18:09:41]

This doesn't seem right. I don't see this template compiling any sources (is
this a bug?) so there's nothing to apply the include_dirs to.

I guess this might depend on how we expect this template to work. If there
aren't supposed to be any sources, then whoever is calling this template
shouldn't be setting any compiler-related stuff on it (like include_dirs). If
there are, we should add the sources, and forward all compiler-related variables
(flags, defines, etc).

[sdefresne, 2015-08-07 18:46:31]

On 2015/08/07 at 18:09:41, brettw wrote:
> This doesn't seem right. I don't see this template compiling any sources (is
this a bug?) so there's nothing to apply the include_dirs to.
> 
> I guess this might depend on how we expect this template to work. If there
aren't supposed to be any sources, then whoever is calling this template
shouldn't be setting any compiler-related stuff on it (like include_dirs). If
there are, we should add the sources, and forward all compiler-related variables
(flags, defines, etc).

You're right I should have forwarded the variables to the
"${target_name}__sources" source_set target. Fixed. Please take another look.

[Dirk Pranke, 2015-08-07 18:53:12]

lgtm, but wait for brett's approval also.

[brettw, 2015-08-07 20:24:58]

https://codereview.chromium.org/1280983003/diff/20001/testing/test.gni
File testing/test.gni (right):

https://codereview.chromium.org/1280983003/diff/20001/testing/test.gni#newcod...
testing/test.gni:156: "cflags",
This list should match up with the set of variables the ios_app expects. I don't
think it takes any cflags or forward_dependent_configs_from, for example

One problem is that the ios_app template has no documentation. Ideally it should
list every argument it takes. I think Dirk has a todo to rationalize this with
the mac app so hopefully we can do that.

[sdefresne, 2015-08-08 10:01:20]

Thank you for the review.

https://codereview.chromium.org/1280983003/diff/20001/testing/test.gni
File testing/test.gni (right):

https://codereview.chromium.org/1280983003/diff/20001/testing/test.gni#newcod...
testing/test.gni:156: "cflags",
On 2015/08/07 at 20:24:58, brettw wrote:
> This list should match up with the set of variables the ios_app expects. I
don't think it takes any cflags or forward_dependent_configs_from, for example
> 
> One problem is that the ios_app template has no documentation. Ideally it
should list every argument it takes. I think Dirk has a todo to rationalize this
with the mac app so hopefully we can do that.

Can this be addressed as a followup CL?

[brettw, 2015-08-08 16:23:02]

lgtm

https://codereview.chromium.org/1280983003/diff/20001/testing/test.gni
File testing/test.gni (right):

https://codereview.chromium.org/1280983003/diff/20001/testing/test.gni#newcod...
testing/test.gni:156: "cflags",
Sure, whatever.

[sdefresne, 2015-08-10 08:53:08]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2015-08-10 08:53:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1280983003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1280983003/20001

[commit-bot: I haz the power, 2015-08-10 09:26:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-10 09:27:15]

Patchset 2 (id:??) landed as
https://crrev.com/66ccebf75ce1139adeec700b036bf9332d2b177f
Cr-Commit-Position: refs/heads/master@{#342596}